Review main Merged

71235[FEATURE] Reintroduce option to modify FE groups w/o auth

Benni Mack CR +2 V +2 Normal +101 −2 updated 10/01/21, 04:36

Commit message

In TYPO3 v11.0 the "getGroupsFE" Authentication chain was removed
for FrontendUserAuthentication, so it is not possible for extensions
to add groups to anonymous user sessions anymore.

A newly introduced Event is now introduced to replace the getGroupsFE
authentication subservice.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1422

  1. Benni Mack uploaded patch set 1 09/24/21, 14:44

  2. core-ci voted on patch set 1 V -1 09/24/21, 15:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17165

  3. Benni Mack rebased onto patch set 2 09/27/21, 07:45

  4. core-ci voted on patch set 2 V -1 09/27/21, 08:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17209

  5. Benni Mack uploaded patch set 3 09/27/21, 08:37

  6. core-ci voted on patch set 3 V +1 09/27/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17212

  7. Benni Mack updated the commit message in patch set 4 09/27/21, 08:57

  8. Benni Mack updated the commit message in patch set 5 09/27/21, 09:04

  9. core-ci voted on patch set 4 V +1 09/27/21, 09:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17215

  10. core-ci voted on patch set 5 V +1 09/27/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17216

  11. Benni Mack updated the commit message in patch set 6 09/27/21, 11:01

  12. core-ci voted on patch set 6 V +1 09/27/21, 11:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17225

  13. Benni Mack uploaded patch set 7 09/27/21, 17:17

  14. core-ci voted on patch set 7 V +1 09/27/21, 17:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17235

  15. Simon Schaufelberger commented on patch set 7 09/27/21, 19:13

    ModifyResolvedFrontendGroupsEvent.php:24

    "even when" or " "even with no user logged in"
  16. Benni Mack commented on patch set 8 09/28/21, 06:51

    Published edit on patch set 7.
  17. Benni Mack commented on patch set 8 09/28/21, 06:51

    ModifyResolvedFrontendGroupsEvent.php:24 Reply

    Ack
  18. core-ci voted on patch set 8 V +1 09/28/21, 07:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17248

  19. Helmut Hummel voted on patch set 8 V +1 CR +1 09/30/21, 15:49

  20. Georg Ringer voted on patch set 8 CR +1 09/30/21, 15:55

  21. Benjamin Franzke voted on patch set 8 V +2 CR +2 10/01/21, 04:36

  22. Benjamin Franzke merged patch set 9 10/01/21, 04:36