Review main Merged

71238[BUGFIX] Remove test data mangling in PHP 8.1 for SQLite

crell CR +2 V +2 Easy +8 −4 updated 09/27/21, 08:51

Commit message

SQLite returns the correct type information now, so this workaround
is not necessary.

As long as we are not on php 8.1 as min requirement, use a version
check to disable the workaround for sqlite and php >8.1.

After 8.1 as minimum requirement the workaround method should be
removed at all.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. crell uploaded patch set 1 09/24/21, 19:40

  2. core-ci voted on patch set 1 V -1 09/24/21, 19:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17173

  3. Oliver Klee commented on patch set 1 09/24/21, 20:09

    AbstractImportExportTestCase.php:113

    Could we simplify the ! < to >= ?
  4. Stefan Bürk uploaded patch set 2 09/25/21, 07:44

  5. Stefan Bürk commented on patch set 2 09/25/21, 07:46

    Incorperated comment from Oliver Klee + rebase. Need's further rebase after nightly fix patch is merged #95357

    AbstractImportExportTestCase.php:113 Reply

    Changed it, and using int instead of version compare. May have a look if it is better now ?
  6. core-ci voted on patch set 2 V +1 09/25/21, 07:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17180

  7. Oliver Klee voted on patch set 2 CR +1 09/25/21, 08:46

  8. Stefan Bürk commented on patch set 2 09/26/21, 13:44

    AbstractImportExportTestCase.php:113 Reply

    Done
  9. Stefan Bürk voted on patch set 2 V +1 CR +1 09/26/21, 13:45

  10. Benni Mack voted on patch set 2 V +2 CR +2 09/27/21, 08:51

  11. Benni Mack merged patch set 3 09/27/21, 08:51