Review main Merged

71239[BUGFIX] Add trailing comma to multiline array in redirects SlugService

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/25/21, 10:52

Commit message

There has been a overlapping in merging two patches, first one
adding rules for php stan to enforce trailing commas for an
multiline array ( #94553 ) and the second one with a multiline
array without trailing comma ( #89327 ).

To make cgl happy again add this comma.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 69

  1. Stefan Bürk uploaded patch set 1 09/25/21, 06:49

  2. Stefan Bürk updated the commit message in patch set 2 09/25/21, 06:51

  3. Stefan Bürk updated the commit message in patch set 3 09/25/21, 07:03

  4. core-ci voted on patch set 1 V +1 09/25/21, 07:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17177

  5. core-ci voted on patch set 2 V +1 09/25/21, 07:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17178

  6. core-ci voted on patch set 3 V +1 09/25/21, 07:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17179

  7. Simon Schaufelberger voted on patch set 3 V +1 CR +1 09/25/21, 08:53

  8. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/25/21, 10:52

  9. Benjamin Franzke merged patch set 4 09/25/21, 10:52