Review main Merged

71252[TASK] Revert "[BUGFIX] Push PackageManager to ExtensionManagementUtility in Bootstrap"

Benjamin Franzke CR +2 V +2 Easy +5 −19 updated 09/25/21, 14:35

Commit message

This reverts commit 11c7e844ed6386d23a6e9c897cc9704c81ef7f80.

The BUGFIX accounted for ExtensionManagementUtility usage in Services.php
which has never been officially supported, but has been a documentation
bug and actually worked only by accident and only in TYPO3 core,
not with tools like typo3-console. Therefore extensions that use this
could always cause breakage in some situations.

The alternative to use optional service dependencies via
ContainerBuilder::hasDefinition() is available since v10
and the documentation is adapted accordingly in #95359.
Therefore the BUGFIX is reverted.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/25/21, 12:35

  2. core-ci voted on patch set 1 V +1 09/25/21, 12:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17184

  3. Helmut Hummel voted on patch set 1 V +1 CR +1 09/25/21, 13:01

  4. Oli Bartsch voted on patch set 1 CR +2 09/25/21, 14:35

  5. Oli Bartsch voted on patch set 1 V +2 09/25/21, 14:35

  6. Oli Bartsch merged patch set 2 09/25/21, 14:35