Review main Merged

71292[BUGFIX] Update composer dev dependencies to min required versions

Stefan Bürk CR +2 V +2 Easy +18 −18 updated 09/27/21, 06:00

Commit message

phpunit has released new versions for 8.5.x and 9.5.x, which
do not longer automaticly throw exception for user depcrecations.
As there are tests expecting this exception, the min version must
be increased and the explicity configuration option set. Otherwise
nightly composerMax unit tests will fail.

Furthermore there was a patch merged which needs to have
'phpspec/prophecy' on ^1.14.0 as minimum requirement. Otherwise
nightly composerMin php7.4 tests will fail.

This patch increase the min version for the two dev dependencies
and apply the needed phpunit configuration option to throw
user deprectation excetions again.

Used composer commands:

composer req --dev --with-dependencies phpunit/phpunit:^9.5.10
composer req --dev phpspec/prophecy:^1.14.0

Tests:

Build/Scripts/runTests.sh -s composerInstallMin -p 7.4 ;  \
  Build/Scripts/runTests.sh -s unit -p 7.4

Build/Scripts/runTests.sh -s composerInstallMax -p 7.4 ;  \
  Build/Scripts/runTests.sh -s unit -p 7.4

Build/Scripts/runTests.sh -s composerInstallMax -p 7.4 ;  \
  Build/Scripts/runTests.sh -s unit -p 8.0

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1216

  1. Stefan Bürk uploaded patch set 1 09/25/21, 14:09

  2. Stefan Bürk commented on patch set 1 09/25/21, 14:14

    Manual nightly is running against this patch: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17187
    Note: Must be ^8.5.21 for v10.4 backport.
  3. Stefan Bürk voted on patch set 1 CR -1 09/25/21, 14:14

  4. core-ci voted on patch set 1 V +1 09/25/21, 14:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17186

  5. core-ci commented on patch set 1 09/25/21, 15:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17187

  6. Stefan Bürk commented on patch set 1 CR 0 09/25/21, 15:09

    > Patch Set 1: > > Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17187 ^ nightly green.
  7. Stefan Bürk commented on patch set 1 V +1 09/25/21, 15:34

    Reply

    Done
  8. Wouter Wolters commented on patch set 1 V +1 CR +1 09/25/21, 16:19

    expecting this exception
  9. Stefan Bürk updated the commit message in patch set 2 09/25/21, 16:43

  10. core-ci voted on patch set 2 V +1 09/25/21, 17:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17190

  11. Stefan Bürk commented on patch set 2 09/26/21, 06:34

    Reply

    Done
  12. Stefan Bürk rebased onto patch set 3 09/26/21, 06:38

  13. core-ci voted on patch set 3 V +1 09/26/21, 06:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17196

  14. Wouter Wolters voted on patch set 3 V +1 CR +1 09/26/21, 08:38

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 09/27/21, 06:00

  16. Andreas Kienast merged patch set 4 09/27/21, 06:00