Review main Merged

71312[DOCS] Create an extension manual for EXT:impexp

Lina Wolf CR +2 V +2 Hard +785 −0 updated 10/04/21, 17:54

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 39

Show 19 more files

Review log 1725

  1. Lina Wolf uploaded patch set 1 09/26/21, 11:00

  2. core-ci voted on patch set 1 V +1 09/26/21, 11:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17197

  3. Benni Mack updated the commit message in patch set 2 09/27/21, 07:44

  4. core-ci voted on patch set 2 V +1 09/27/21, 08:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17208

  5. Alexander Nitsche uploaded patch set 3 10/01/21, 14:15

  6. Alexander Nitsche commented on patch set 3 10/01/21, 14:18

    Patch set 3 fixes the rendering warnings and an infinite rendering loop in `typo3/sysext/impexp/Documentation/Usage/Presets.rst`.
  7. core-ci voted on patch set 3 V +1 10/01/21, 14:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17441

  8. Torben Hansen commented on patch set 3 10/02/21, 16:58

    Index.rst:17

    This just hides the menu item in the context menu. However, the export action is still callable, so I think it is better to remove the sentence.

    Index.rst:20

    Please remove "public", since the path only applies to composer installations.
  9. Lina Wolf uploaded patch set 4 10/03/21, 06:46

  10. core-ci voted on patch set 4 V +1 10/03/21, 07:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17499

  11. Alexander Nitsche uploaded patch set 5 10/04/21, 10:25

  12. Alexander Nitsche commented on patch set 5 10/04/21, 10:27

    First part reviewed .. heading later to the second.
  13. Nikita Hovratov uploaded patch set 6 10/04/21, 10:27

  14. Nikita Hovratov uploaded patch set 7 10/04/21, 10:35

  15. Nikita Hovratov commented on patch set 7 10/04/21, 10:40

    ContextMenuExport.rst.txt:7 Unresolved

    Select Then

    Index.rst:17 Reply

    Done
  16. core-ci voted on patch set 5 V +1 10/04/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17545

  17. Nikita Hovratov commented on patch set 7 10/04/21, 10:41

    Index.rst:20 Reply

    Done
  18. core-ci voted on patch set 6 V +1 10/04/21, 10:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17546

  19. core-ci voted on patch set 7 V +1 10/04/21, 10:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17547

  20. Tom Warwick uploaded patch set 8 10/04/21, 17:33

  21. Tom Warwick commented on patch set 8 10/04/21, 17:35

    As requested by Lina, we improved the wording and rewrote parts of it to make the meaning easier to grasp.
  22. core-ci voted on patch set 8 V +1 10/04/21, 17:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17580

  23. Susi Moog voted on patch set 8 V +1 CR +1 10/04/21, 17:51

  24. Benni Mack voted on patch set 8 V +2 CR +2 10/04/21, 17:54

  25. Benni Mack merged patch set 9 10/04/21, 17:54