71313[TASK] Add tests to cover eID controller requests
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_eid/Classes/Eid/EidAutoResponder.php3new+47 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_eid/ext_emconf.php3new+22 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_eid/ext_localconf.phpnew+9 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php3new+262 −0
Review log 1418
-
Stefan Bürk uploaded patch set 1 09/26/21, 19:56
-
core-ci voted on patch set 1 V +1 09/26/21, 20:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17200
-
Andreas Kienast commented on patch set 1 CR -1 09/27/21, 06:14
-
Stefan Bürk uploaded patch set 2 09/27/21, 07:18
-
Stefan Bürk commented on patch set 2 09/27/21, 07:20
EidAutoResponder.php:31ReplyUndeleted left-over. Copied stuff from a v9 project first and did not cleanup correctly. Thx for pointing. Removed now. -
core-ci voted on patch set 2 V +1 09/27/21, 07:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17207
-
Benni Mack voted on patch set 2 V +1 CR +1 09/27/21, 11:13
-
Stefan Bürk commented on patch set 2 09/28/21, 09:39
EidAutoResponder.php:31ReplyDone -
Andreas Kienast updated the commit message in patch set 3 09/28/21, 10:06
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/28/21, 10:06
-
core-ci voted on patch set 3 V +1 09/28/21, 10:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17254
-
Oli Bartsch commented on patch set 3 09/28/21, 10:35
Will update in a minuteext_emconf.php:18AFAICS the test extension does not really rely on workspaces.EidRequestTest.php:4License information missing here. -
Oli Bartsch uploaded patch set 4 09/28/21, 10:36
-
Stefan Bürk commented on patch set 4 09/28/21, 10:38
Thx Andreas Fernandez and Oliver Bartsch for helping out.ext_emconf.php:18ReplyRight. Sry for missing that.EidRequestTest.php:4ReplyNot checked, thought would be detected&added by cglFixMyCommit - was wrong and did not rechecked it. Thanks. -
Oli Bartsch commented on patch set 4 V +1 CR +1 09/28/21, 10:42
ext_emconf.php:18ReplyDoneEidRequestTest.php:4ReplyDone -
core-ci voted on patch set 4 V +1 09/28/21, 10:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17256
-
Andreas Kienast voted on patch set 4 V +2 CR +2 09/28/21, 11:16
-
Andreas Kienast merged patch set 5 09/28/21, 11:16
EidAutoResponder.php:31