Review main Merged

71313[TASK] Add tests to cover eID controller requests

Stefan Bürk CR +2 V +2 Hard +340 −0 updated 09/28/21, 11:16

Commit message

To cover that eID requests are working, this patch
adds a test extension which registers a simple responder
eID script, which response with some request informations
as json response.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1418

  1. Stefan Bürk uploaded patch set 1 09/26/21, 19:56

  2. core-ci voted on patch set 1 V +1 09/26/21, 20:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17200

  3. Andreas Kienast commented on patch set 1 CR -1 09/27/21, 06:14

    EidAutoResponder.php:31

    What's up with the commented code?
  4. Stefan Bürk uploaded patch set 2 09/27/21, 07:18

  5. Stefan Bürk commented on patch set 2 09/27/21, 07:20

    EidAutoResponder.php:31 Reply

    Undeleted left-over. Copied stuff from a v9 project first and did not cleanup correctly. Thx for pointing. Removed now.
  6. core-ci voted on patch set 2 V +1 09/27/21, 07:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17207

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/27/21, 11:13

  8. Stefan Bürk commented on patch set 2 09/28/21, 09:39

    EidAutoResponder.php:31 Reply

    Done
  9. Andreas Kienast updated the commit message in patch set 3 09/28/21, 10:06

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 09/28/21, 10:06

  11. core-ci voted on patch set 3 V +1 09/28/21, 10:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17254

  12. Oli Bartsch commented on patch set 3 09/28/21, 10:35

    Will update in a minute

    ext_emconf.php:18

    AFAICS the test extension does not really rely on workspaces.

    EidRequestTest.php:4

    License information missing here.
  13. Oli Bartsch uploaded patch set 4 09/28/21, 10:36

  14. Stefan Bürk commented on patch set 4 09/28/21, 10:38

    Thx Andreas Fernandez and Oliver Bartsch for helping out.

    ext_emconf.php:18 Reply

    Right. Sry for missing that.

    EidRequestTest.php:4 Reply

    Not checked, thought would be detected&added by cglFixMyCommit - was wrong and did not rechecked it. Thanks.
  15. Oli Bartsch commented on patch set 4 V +1 CR +1 09/28/21, 10:42

    ext_emconf.php:18 Reply

    Done

    EidRequestTest.php:4 Reply

    Done
  16. core-ci voted on patch set 4 V +1 09/28/21, 10:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17256

  17. Andreas Kienast voted on patch set 4 V +2 CR +2 09/28/21, 11:16

  18. Andreas Kienast merged patch set 5 09/28/21, 11:16