Review main Merged

71314[TASK] Add xl and xxl breakpoints to Form definitions

Benni Mack CR +2 V +2 Normal +139 −2 updated 09/28/21, 07:58

Commit message

This change adds XL and XXL breakpoints to the
EXT:form FormElement definitions.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Björn Jacob +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Björn Jacob +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1315

  1. Benni Mack uploaded patch set 1 09/27/21, 08:11

  2. core-ci voted on patch set 1 V +1 09/27/21, 08:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17210

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 09/27/21, 09:19

  4. Nikita Hovratov uploaded patch set 2 09/27/21, 15:08

  5. Nikita Hovratov commented on patch set 2 09/27/21, 15:10

    A suggestion: Use the abbreviations for button text, so the buttons still fit into one row without overflow. The full label is visible as title on hover.
  6. core-ci voted on patch set 2 V +1 09/27/21, 15:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17230

  7. Benni Mack commented on patch set 2 09/27/21, 16:37

    Reply

    Fine by me, want to take care of it?
  8. Nikita Hovratov commented on patch set 2 09/27/21, 16:44

    Reply

    Already did :)
  9. Oliver Hader voted on patch set 2 CR +1 09/27/21, 17:51

  10. Oliver Hader voted on patch set 2 V +1 09/27/21, 18:04

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 09/27/21, 21:32

  12. Benni Mack commented on patch set 2 09/28/21, 06:52

    Reply

    Ack
  13. Björn Jacob voted on patch set 2 V +1 CR +1 09/28/21, 07:40

  14. Oli Bartsch voted on patch set 2 V +2 CR +2 09/28/21, 07:58

  15. Oli Bartsch merged patch set 3 09/28/21, 07:58