Review 10.4 Abandoned

71315[TASK] Merge phpunit setup files to Build/phpunit

Stefan Bürk CR 0 V 0 Hard +266 −25 updated 09/27/21, 09:03

Commit message

typo3/testing-framework ships default .xml and
bootstrap files for phpunit unit and functional tests.

They are however quite hard to maintain since the
testing-framework supports multiple core versions at
once, but core occassionally needs version specific
settings.

The patch copies the files from the testing-framework
to Build/phpunit and adapts core usages.

The files within testing-framework will be kept, but
will receive an additional "these are boilerplates,
consider copying them to your extension" hint for
extension developers.

The local .xml files are now:
* Compatible with phpunit 9
* Let tests fail if phpunit marks a test with warning.
  With this enabled, we would have seen the issues
  fixed with #94724 and #94723 with initial #94706
  already. Good to do that now.

Review

  • Code review CR 0
  • Verified V 0

Issues 4

Files 10

Review log 47

  1. Stefan Bürk uploaded patch set 1 09/27/21, 08:37

  2. Stefan Bürk commented on patch set 1 09/27/21, 08:40

  3. Stefan Bürk updated the commit message in patch set 2 09/27/21, 08:41

  4. core-ci voted on patch set 1 V -1 09/27/21, 08:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17211

  5. core-ci voted on patch set 1 V -1 09/27/21, 08:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17213

  6. core-ci voted on patch set 2 V -1 09/27/21, 08:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17214

  7. Stefan Bürk abandoned the change 09/27/21, 09:03

    Backport not working, and work to fix failing unitDeprecations are not appropiate. So cancel the test.