Review main Merged

71317[BUGFIX] Clarify requested token vs. missing token in Backend deeplinks

Benni Mack CR +2 V +2 Normal +67 −24 updated 09/30/21, 09:43

Commit message

This change separates between a missing CSRF token and an invalid
request token in the backend redirect functionality, ensuring
that the token is given (= redirect) instead of wrong (= redirect
to log in page).

In addition, the redirect links are now only generated if a route
is not limited to POST (this was added in 11.1 later-on).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Benni Mack uploaded patch set 1 09/27/21, 11:33

  2. core-ci voted on patch set 1 V +1 09/27/21, 11:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17227

  3. Oli Bartsch uploaded patch set 2 09/28/21, 11:16

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 09/28/21, 11:17

  5. Oli Bartsch uploaded patch set 3 09/28/21, 11:35

  6. core-ci voted on patch set 2 V +1 09/28/21, 11:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17257

  7. core-ci voted on patch set 3 V +1 09/28/21, 11:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17260

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 09/29/21, 08:02

  9. Oliver Hader commented on patch set 3 CR -1 09/30/21, 09:12

    BackendController.php:385 Unresolved

    + ensure current `$request` is GET
  10. Oliver Hader uploaded patch set 4 09/30/21, 09:19

  11. Oliver Hader voted on patch set 4 V +1 CR +1 09/30/21, 09:19

  12. core-ci voted on patch set 4 V +1 09/30/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17328

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 09/30/21, 09:43

  14. Oli Bartsch merged patch set 5 09/30/21, 09:43