71318[TASK] Get rid of inline JavaScript in new content element wizard
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Hader +1
- core-ci +1 CI
Issues 3
Files 25
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Wizard/NewContentElement.tsdeleted+0 −50
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts+7 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/NewContentElementWizard.ts4+89 −37
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/NewContentElementWizardButton.ts2new+68 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts2+20 −8
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+93 −109
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+8 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −0
- typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php+48 −13
- typo3/sysext/backend/Configuration/Backend/Routes.php+1 −1
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+16 −5
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+16 −5
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Main.htmldeleted+0 −66
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/MenuItem.html+21 −32
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/PositionMap.htmlnew+6 −0
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Wizard.htmlnew+30 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Wizard/NewContentElement.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/NewContentElementWizard.js+1 −1
Show 5 more files
- typo3/sysext/backend/Resources/Public/JavaScript/NewContentElementWizardButton.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+7 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+2 −2
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+39 −32
Review log 1825
-
Oli Bartsch uploaded patch set 1 09/27/21, 13:45
-
core-ci voted on patch set 1 V -1 09/27/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17228
-
Oli Bartsch uploaded patch set 2 09/27/21, 16:12
-
core-ci voted on patch set 2 V -1 09/27/21, 16:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17233
-
Oli Bartsch uploaded patch set 3 09/27/21, 18:12
-
core-ci voted on patch set 3 V -1 09/27/21, 18:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17238
-
Oli Bartsch uploaded patch set 4 09/27/21, 20:37
-
core-ci voted on patch set 4 V +1 09/27/21, 20:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17241
-
Oli Bartsch updated the commit message in patch set 5 09/27/21, 21:05
-
core-ci voted on patch set 5 V +1 09/27/21, 21:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17243
-
Benni Mack voted on patch set 5 V +1 CR +1 09/28/21, 13:29
-
Oliver Hader uploaded patch set 6 09/28/21, 20:05
-
Oliver Hader commented on patch set 6 V +1 CR +1 09/28/21, 20:06
NewContentElementWizard.ts:60Naming nitpick: Actually would be `ClassNames.wizardWindow` and `querySelector('.' + ClassNames.wizardWindow)` - as a selector also might be (in theory) something like `'#my-identifier'` (not a CSS class-name)NewContentElementWizardButton.ts:28I think we used `endpoint` already, but actually `url` or even `href` would be (semantically) nice.PageActions.ts:234if (`element instanceof HTMLAnchorElement`) would avoid later (`element as ...`) hint -
core-ci voted on patch set 6 V +1 09/28/21, 20:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17279
-
Oli Bartsch commented on patch set 6 V -1 09/28/21, 21:28
On it. -
Oli Bartsch uploaded patch set 7 09/28/21, 22:10
-
Oli Bartsch commented on patch set 7 09/28/21, 22:12
NewContentElementWizard.ts:41ReplyDoneNewContentElementWizard.ts:60ReplyAdded this specific use case as ClassNames.wizardWindow now.NewContentElementWizardButton.ts:28ReplyDonePageActions.ts:234ReplyDone -
core-ci voted on patch set 7 V +1 09/28/21, 22:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17285
-
Oliver Hader voted on patch set 7 CR +1 09/29/21, 06:50
-
Oliver Hader voted on patch set 7 V +1 09/29/21, 06:59
-
Oliver Hader wrote 09/29/21, 06:59
Topic set to inline-javascript -
Benni Mack voted on patch set 7 V +2 CR +2 09/29/21, 07:39
-
Benni Mack merged patch set 8 09/29/21, 07:39
-
Benjamin Franzke commented on patch set 8 10/01/21, 20:31
FYI, caused a regression: https://forge.typo3.org/issues/95440 -
Oliver Hader commented on patch set 8 10/02/21, 13:41
Reply
Fixed. Thx for taking care!
NewContentElementWizard.ts:41