Review main Merged

71332[TASK] Avoid referencing public assets across packages

Helmut Hummel CR +2 V +2 Normal +38 −51 updated 09/28/21, 12:21

Commit message

Since TYPO3 core packages (extensions) are independently
published and might be installed in arbitrary file locations
in the near future, referencing assets in package A
from a CSS file package B will likely not work.

Therefore all assets that are referenced from a CSS
file are now moved to the package that contains this CSS file.

Also references of assets in CSS that already were located
in the same package are cleaned up to not assume a hard coded
path name (breaking out of Resources/Public directory).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 69

  1. Helmut Hummel uploaded patch set 1 09/27/21, 15:57

  2. core-ci voted on patch set 1 V -1 09/27/21, 16:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17232

  3. Benjamin Franzke uploaded patch set 2 09/27/21, 20:06

  4. core-ci voted on patch set 2 V -1 09/27/21, 20:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17240

  5. Benjamin Franzke uploaded patch set 3 09/27/21, 20:39

  6. core-ci voted on patch set 3 V +1 09/27/21, 20:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17242

  7. Benni Mack voted on patch set 3 V +2 CR +2 09/28/21, 09:36

  8. Benni Mack merged patch set 4 09/28/21, 09:36

  9. Helmut Hummel commented on patch set 4 09/28/21, 12:21

    Thanks a bunch. Now not much is missing for extensions being able to reside in vendor folder