Review main Merged

71336[BUGFIX] Use correct variable in CheckboxElement

Georg Ringer CR +2 V +2 Easy +1 −3 updated 09/29/21, 16:55

Commit message

The 2nd argument for the method `renderSingleCheckboxElement` must be
the number of the element of the given list.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 09/28/21, 06:57

  2. Georg Ringer commented on patch set 1 09/28/21, 07:01

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/28/21, 07:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17249

  4. Oli Bartsch commented on patch set 1 09/28/21, 10:02

    So $counter is then superfluous in the "else", right?
  5. Nikita Hovratov uploaded patch set 2 09/28/21, 15:19

  6. core-ci voted on patch set 2 V +1 09/28/21, 15:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17272

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 09/29/21, 06:54

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 09/29/21, 16:55

  9. Oli Bartsch merged patch set 3 09/29/21, 16:55