Review main Merged

71337[TASK] Split up "new page" functionality into separate action

Benni Mack CR +2 V +2 Normal +77 −86 updated 10/04/21, 14:21

Commit message

Previously, the "pagesOnly" argument was used
to link to the PagePositionMap for new pages.

This is now resolved by using an actual separate
route "db_new_pages" to link to the PagePositionMap
to avoid the "special" handling of "pagesOnly", which
still works but creates a redirect to the new route.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1322

  1. Benni Mack uploaded patch set 1 09/28/21, 09:41

  2. core-ci voted on patch set 1 V +1 09/28/21, 09:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17252

  3. Benni Mack uploaded patch set 2 09/29/21, 08:00

  4. core-ci voted on patch set 2 V +1 09/29/21, 08:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17298

  5. Benni Mack updated the commit message in patch set 3 09/30/21, 14:05

  6. core-ci voted on patch set 3 V +1 09/30/21, 14:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17343

  7. Anja Leichsenring commented on patch set 3 V -1 09/30/21, 19:06

    when patch applied and invoked from page tree -> More Options -> 'create new' wizard, the whole frame set appears in the main frame.
  8. Benni Mack uploaded patch set 4 10/01/21, 13:10

  9. core-ci voted on patch set 4 V +1 10/01/21, 13:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17429

  10. Nikita Hovratov uploaded patch set 5 10/01/21, 16:43

  11. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/01/21, 16:44

  12. core-ci voted on patch set 5 V -1 10/01/21, 17:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17454

  13. Nikita Hovratov commented on patch set 5 10/01/21, 17:08

    > Patch Set 5: Verified-1 > > Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17454 needs restart, I think.
  14. core-ci commented on patch set 5 10/02/21, 09:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17454

  15. core-ci commented on patch set 5 10/02/21, 10:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17454

  16. core-ci voted on patch set 5 V +1 10/02/21, 10:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17454

  17. Oli Bartsch uploaded patch set 6 10/04/21, 13:55

  18. Oli Bartsch voted on patch set 6 V +1 CR +1 10/04/21, 13:55

  19. core-ci voted on patch set 6 V +1 10/04/21, 14:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17563

  20. Nikita Hovratov voted on patch set 6 V +1 CR +1 10/04/21, 14:13

  21. Oli Bartsch voted on patch set 6 V +2 CR +2 10/04/21, 14:20

  22. Oli Bartsch merged patch set 7 10/04/21, 14:21