Review main Merged

71338[TASK] Clean up EXT:linkvalidator CSS and JavaScript

Oli Bartsch CR +2 V +2 Hard +110 −218 updated 09/29/21, 16:50

Commit message

The EXT:linkvalidator module specific stylesheet is
removed in favor of using the bootstrap framework.
Besides increased consistency this also leads to less
custom classes and old fashioned styles.

The JavaScript component of the module is refactored
to avoid jQuery, while the code is simplified and type
hinted.

Additionally, some improvements to the module
are done. For example, proper spacing and usage
of the toggle switches.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1215

  1. Oli Bartsch uploaded patch set 1 09/28/21, 09:43

  2. Benni Mack commented on patch set 1 09/28/21, 09:48

    Gruntfile still contains the linkvalidator.scss
  3. Benni Mack commented on patch set 1 09/28/21, 09:49

    Linkvalidator.ts:46

    can we also add a timeout (5sec) to automatically fade out the notification at some point?
  4. core-ci voted on patch set 1 V +1 09/28/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17253

  5. Oli Bartsch uploaded patch set 2 09/28/21, 10:09

  6. Benni Mack commented on patch set 2 CR +1 09/28/21, 10:09

    Linkvalidator.ts:46 Reply

    Done
  7. Oli Bartsch commented on patch set 2 09/28/21, 10:11

    Reply

    Done

    Linkvalidator.ts:46 Reply

    Default duration of notifications is 5 sec. I set 2 now, since the information is of little use as it only tells "ok, you clicked a button now we do something". This is now the same duration as the file download uses for the "download is prepared" message.
  8. core-ci voted on patch set 2 V +1 09/28/21, 10:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17255

  9. Benni Mack voted on patch set 2 V +1 09/28/21, 12:28

  10. Benni Mack updated the commit message in patch set 3 09/28/21, 13:09

  11. core-ci voted on patch set 3 V +1 09/28/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17263

  12. Benni Mack voted on patch set 3 V +1 CR +1 09/28/21, 14:42

  13. Jochen Roth voted on patch set 3 V +1 CR +1 09/29/21, 09:07

  14. Oli Bartsch voted on patch set 3 V +2 CR +2 09/29/21, 16:50

  15. Oli Bartsch merged patch set 4 09/29/21, 16:50