71338[TASK] Clean up EXT:linkvalidator CSS and JavaScript
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/Sass/linkvalidator.scssdeleted+0 −81
- Build/Sources/TypeScript/linkvalidator/Resources/Public/TypeScript/Linkvalidator.ts3+23 −36
- Build/Gruntfile.js+0 −5
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+13 −20
- typo3/sysext/linkvalidator/Resources/Private/Layouts/TabContent.html+42 −33
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/CheckLinksTab.html+1 −1
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/ReportTab.html+30 −28
- typo3/sysext/linkvalidator/Resources/Public/Css/linkvalidator.cssdeleted+0 −13
- typo3/sysext/linkvalidator/Resources/Public/JavaScript/Linkvalidator.js+1 −1
Review log 1215
-
Oli Bartsch uploaded patch set 1 09/28/21, 09:43
-
Benni Mack commented on patch set 1 09/28/21, 09:48
Gruntfile still contains the linkvalidator.scss -
Benni Mack commented on patch set 1 09/28/21, 09:49
Linkvalidator.ts:46can we also add a timeout (5sec) to automatically fade out the notification at some point? -
core-ci voted on patch set 1 V +1 09/28/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17253
-
Oli Bartsch uploaded patch set 2 09/28/21, 10:09
-
Benni Mack commented on patch set 2 CR +1 09/28/21, 10:09
Linkvalidator.ts:46ReplyDone -
Oli Bartsch commented on patch set 2 09/28/21, 10:11
Reply
DoneLinkvalidator.ts:46ReplyDefault duration of notifications is 5 sec. I set 2 now, since the information is of little use as it only tells "ok, you clicked a button now we do something". This is now the same duration as the file download uses for the "download is prepared" message. -
core-ci voted on patch set 2 V +1 09/28/21, 10:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17255
-
Benni Mack voted on patch set 2 V +1 09/28/21, 12:28
-
Benni Mack updated the commit message in patch set 3 09/28/21, 13:09
-
core-ci voted on patch set 3 V +1 09/28/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17263
-
Benni Mack voted on patch set 3 V +1 CR +1 09/28/21, 14:42
-
Jochen Roth voted on patch set 3 V +1 CR +1 09/29/21, 09:07
-
Oli Bartsch voted on patch set 3 V +2 CR +2 09/29/21, 16:50
-
Oli Bartsch merged patch set 4 09/29/21, 16:50