Review main Merged

71340[BUGFIX] Save correct table name as ref_table in refindex

Nikita Hovratov CR +2 V +2 Easy +17 −4 updated 11/09/21, 16:04

Commit message

The identifier from the linkHandler page TSconfig was formerly used as
the reference table name "ref_table". This identifier is free to choose
and shouldn't be interpreted as a name of a table.

In order to resolve the correct table name, which is stated in the
configuration, the page id of the reference record is now used. This
allows the TypolinkSoftReferenceParser to read the according page
TSconfig and to set the correct table name.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1525

  1. Nikita Hovratov uploaded patch set 1 09/28/21, 14:03

  2. Tobias Wollender commented on patch set 1 09/28/21, 14:07

    Should be #95380 I think?
  3. Nikita Hovratov updated the commit message in patch set 2 09/28/21, 14:15

  4. Nikita Hovratov commented on patch set 2 09/28/21, 14:16

    Reply

    Done
  5. core-ci voted on patch set 1 V -1 09/28/21, 14:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17266

  6. core-ci voted on patch set 2 V -1 09/28/21, 14:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17267

  7. Nikita Hovratov uploaded patch set 3 09/28/21, 14:39

  8. core-ci voted on patch set 3 V -1 09/28/21, 14:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17269

  9. Nikita Hovratov uploaded patch set 4 09/28/21, 15:05

  10. core-ci voted on patch set 4 V +1 09/28/21, 15:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17270

  11. Benni Mack uploaded patch set 5 11/05/21, 11:31

  12. core-ci voted on patch set 5 V +1 11/05/21, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18941

  13. Oli Bartsch commented on patch set 5 CR -1 11/08/21, 21:36

    Hi Nikita. I think this patch mostly fixes the issue but seems to be a bit cumbersome. AFAICS the PID can easily be retrieved in the parser directly. So there should be no need to pass it through all these classes. Additionally the current state will most likely fail for (new) pages, especially when on root level. I would like to propose another solution, accessing the PID directly in the parser. I will upload a new patchset shortly.
  14. Oli Bartsch uploaded patch set 6 11/08/21, 21:58

  15. core-ci voted on patch set 6 V -1 11/08/21, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19050

  16. Oli Bartsch uploaded patch set 7 11/08/21, 22:17

  17. core-ci voted on patch set 7 V -1 11/08/21, 23:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19051

  18. core-ci commented on patch set 7 11/08/21, 23:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19051

  19. core-ci commented on patch set 7 11/09/21, 00:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19051

  20. Nikita Hovratov commented on patch set 7 11/09/21, 08:01

    Reply

    Thanks Oli, I had a feeling this could be simplified :)
  21. Nikita Hovratov rebased onto patch set 8 11/09/21, 08:13

  22. core-ci voted on patch set 8 V +1 11/09/21, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19056

  23. Nikita Hovratov voted on patch set 8 V +1 CR +1 11/09/21, 08:42

  24. Christian Kuhn voted on patch set 8 V +2 CR +2 11/09/21, 16:04

  25. Christian Kuhn merged patch set 9 11/09/21, 16:04