Review main Merged

71342[BUGFIX] Relocate menu generation in PageLayoutController

Oli Bartsch CR +2 V +2 Easy +6 −11 updated 09/30/21, 03:51

Commit message

Since #92460, the PageLayoutController has to deal
with the special "ALL languages" option. Therefore,
a couple of checks are performed in menuConfig()
to determine whether the special language should
be applied to the menu or not.

It's therefore necessary to move the actual menu
generation after this determination.

This patch also removes a duplicated call to the
makeLanguageMenu() method.

Additionally, the special language is only
added to the language menu, in case at least
one translation of the current page exists.
Previously, the "available" languages were
checked. This makes no sense, since they
might be available, but not yet used.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/28/21, 16:00

  2. core-ci voted on patch set 1 V +1 09/28/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17273

  3. Jochen Roth voted on patch set 1 V +1 CR +1 09/29/21, 09:32

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 09/29/21, 13:24

  5. Georg Ringer voted on patch set 1 V +2 CR +2 09/30/21, 03:50

  6. Georg Ringer merged patch set 2 09/30/21, 03:51