71343[BUGFIX] Remove EXT:backend dependencies from errorpage.css
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 17
- Build/Sources/Sass/errorpage.scss+28 −58
- Build/Gruntfile.js+1 −1
- typo3/sysext/backend/Classes/View/AuthenticationStyleInformation.php+3 −3
- typo3/sysext/backend/Resources/Private/Partials/About/Logo.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/errorpage.cssdeleted+0 −13
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+2 −2
- typo3/sysext/core/Resources/Private/Layouts/SystemEmail.html+2 −2
- typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html3+6 −3
- typo3/sysext/core/Resources/Public/Css/errorpage.cssnew+13 −0
- typo3/sysext/core/Resources/Public/Images/typo3_black.svgrenamed+0 −0
- typo3/sysext/core/Resources/Public/Images/typo3_orange.svgrenamed+0 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/T3GeneralInformationWidget.html+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+2 −2
- typo3/sysext/install/Resources/Private/Templates/Installer/MainLayout.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Login/ShowEnableInstallToolFile.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Login/ShowLogin.html+1 −1
- typo3/sysext/install/Resources/Public/Images/typo3_orange.svgdeleted+0 −15
Review log 1521
-
Oli Bartsch uploaded patch set 1 09/28/21, 20:42
-
Oli Bartsch updated the commit message in patch set 2 09/28/21, 20:42
-
core-ci voted on patch set 1 V -1 09/28/21, 20:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17280
-
core-ci voted on patch set 2 V -1 09/28/21, 21:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17281
-
Oli Bartsch uploaded patch set 3 09/28/21, 21:23
-
core-ci voted on patch set 3 V +1 09/28/21, 21:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17282
-
Helmut Hummel voted on patch set 3 V +1 CR +1 09/28/21, 21:58
-
Oli Bartsch uploaded patch set 4 09/28/21, 22:40
-
core-ci voted on patch set 4 V +1 09/28/21, 22:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17288
-
Benjamin Franzke commented on patch set 4 CR -1 09/29/21, 06:16
-
Benjamin Franzke uploaded patch set 5 09/29/21, 06:17
-
Benjamin Franzke commented on patch set 5 09/29/21, 06:17
Error.html:18ReplyAdapted in patchset 5, feel free to rollback to patchset 4 if you really think that <core:icon> is safe. -
Benjamin Franzke uploaded patch set 6 09/29/21, 06:18
-
core-ci voted on patch set 6 V -1 09/29/21, 06:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17293
-
Nikita Hovratov uploaded patch set 7 09/29/21, 07:37
-
Benjamin Franzke voted on patch set 7 V +1 CR +1 09/29/21, 07:41
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 09/29/21, 07:44
-
core-ci voted on patch set 7 V +1 09/29/21, 07:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17296
-
Benni Mack commented on patch set 7 09/29/21, 07:54
did not test, but very nice change indeed! -
Oli Bartsch commented on patch set 7 V +2 CR +2 09/29/21, 08:24
Error.html:18ReplyI also used inline markup first but then switched to the VH because this way we don't have to adapt the template when the iconset changes. However, I completely share your concerns regarding the IconFactory / Icon dependencies. Let's stay with inline markup for now. -
Oli Bartsch merged patch set 8 09/29/21, 08:24
Error.html:18