Review main Merged

71343[BUGFIX] Remove EXT:backend dependencies from errorpage.css

Oli Bartsch CR +2 V +2 Normal +62 −104 updated 09/29/21, 08:24

Commit message

In #95372 the errorpage.css, used for the standalone
ErrorPage template, was moved from EXT:core to
EXT:backend, since it had dependencies to this
extension. However, it actually belongs to EXT:core.
The ErrorPageController is used for both, backend
and frontend.

A side effect of the relocation to EXT:backend: The
errorpage.css was now always loaded in the backend,
overriding a couple of classes, which then led to
display errors.

This is now fixed by removing any dependency to
EXT:backend and moving the stylesheet back to
EXT:core.

As a side effect, the "typo3_orange.svg" file
is removed from EXT:backend and EXT:install,
since it's now available in EXT:core. All
places are adjusted accordingly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1521

  1. Oli Bartsch uploaded patch set 1 09/28/21, 20:42

  2. Oli Bartsch updated the commit message in patch set 2 09/28/21, 20:42

  3. core-ci voted on patch set 1 V -1 09/28/21, 20:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17280

  4. core-ci voted on patch set 2 V -1 09/28/21, 21:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17281

  5. Oli Bartsch uploaded patch set 3 09/28/21, 21:23

  6. core-ci voted on patch set 3 V +1 09/28/21, 21:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17282

  7. Helmut Hummel voted on patch set 3 V +1 CR +1 09/28/21, 21:58

  8. Oli Bartsch uploaded patch set 4 09/28/21, 22:40

  9. core-ci voted on patch set 4 V +1 09/28/21, 22:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17288

  10. Benjamin Franzke commented on patch set 4 CR -1 09/29/21, 06:16

    Error.html:18

    I know, this is not an exception handler, but I still have a bad feeling using the IconViewHelper here (which uses IconFactory and can thus potentially fail in ugly ways). I'd go the save route and add an inline svg here.
  11. Benjamin Franzke uploaded patch set 5 09/29/21, 06:17

  12. Benjamin Franzke commented on patch set 5 09/29/21, 06:17

    Error.html:18 Reply

    Adapted in patchset 5, feel free to rollback to patchset 4 if you really think that <core:icon> is safe.
  13. Benjamin Franzke uploaded patch set 6 09/29/21, 06:18

  14. core-ci voted on patch set 6 V -1 09/29/21, 06:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17293

  15. Nikita Hovratov uploaded patch set 7 09/29/21, 07:37

  16. Benjamin Franzke voted on patch set 7 V +1 CR +1 09/29/21, 07:41

  17. Nikita Hovratov voted on patch set 7 V +1 CR +1 09/29/21, 07:44

  18. core-ci voted on patch set 7 V +1 09/29/21, 07:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17296

  19. Benni Mack commented on patch set 7 09/29/21, 07:54

    did not test, but very nice change indeed!
  20. Oli Bartsch commented on patch set 7 V +2 CR +2 09/29/21, 08:24

    Error.html:18 Reply

    I also used inline markup first but then switched to the VH because this way we don't have to adapt the template when the iconset changes. However, I completely share your concerns regarding the IconFactory / Icon dependencies. Let's stay with inline markup for now.
  21. Oli Bartsch merged patch set 8 09/29/21, 08:24