Review main Merged

71347[BUGFIX] Add support for DateTimeImmutable in JsonView

Oliver Eglseder CR +2 V +2 Easy +6 −1 updated 09/30/21, 11:43

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Eglseder uploaded patch set 1 09/29/21, 08:41

  2. Andreas Kienast commented on patch set 1 09/29/21, 08:45

    JsonView.php:374

    `$object instanceof \DateTimeInterface` should do the same and cover both cases, shouldn't it?
  3. core-ci voted on patch set 1 V +1 09/29/21, 08:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17301

  4. Oliver Eglseder uploaded patch set 2 09/29/21, 10:00

  5. core-ci voted on patch set 2 V +1 09/29/21, 10:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17308

  6. Benni Mack voted on patch set 2 CR +1 09/30/21, 07:04

  7. Oliver Klee voted on patch set 2 CR +1 09/30/21, 08:34

  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 09/30/21, 10:53

  9. Christian Kuhn commented on patch set 2 09/30/21, 11:36

    JsonView.php:374 Reply

    Done
  10. Christian Kuhn voted on patch set 2 V +2 CR +2 09/30/21, 11:43

  11. Christian Kuhn merged patch set 3 09/30/21, 11:43