71356[BUGFIX] Respect query string for regexp redirects
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/redirects/Classes/Service/RedirectService.php+41 −4
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_regexp.xmlnew+151 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+130 −19
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+61 −0
Review log 68
-
Benni Mack commented on patch set 1 10/04/21, 16:47
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Service/RedirectService.php * typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php -
Benni Mack marked it ready for review 10/04/21, 16:48
-
core-ci voted on patch set 1 V -1 10/04/21, 16:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17578
-
Stefan Bürk uploaded patch set 2 10/04/21, 17:39
-
core-ci voted on patch set 2 V +1 10/04/21, 17:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17581
-
Stefan Bürk voted on patch set 2 V +1 CR +1 10/04/21, 17:52
-
Benni Mack voted on patch set 2 V +2 CR +2 10/04/21, 17:54
-
Benni Mack merged patch set 3 10/04/21, 17:54