Review 10.4 Merged

71356[BUGFIX] Respect query string for regexp redirects

Benni Mack CR +2 V +2 Hard +383 −23 updated 10/04/21, 17:54

Commit message

Backend redirect record edit form was not clear about the
fact that regular expression do not respect query parameter
if selected too. RegExp matching has been done only with
the path, even if the request has query parameters.

Thus it was not obvious to users why regular expression
evaluation against query parameter part has not been
matched.

To mitigate this regular expression redirects are matched
against path and query if respect_query_parameters was
set, otherwise against path only.

There may be instances with regexp redirects not covering
query parameters as that have not been checked in the past,
thus we need do a second match only against path to keep
them working.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Benni Mack commented on patch set 1 10/04/21, 16:47

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Service/RedirectService.php * typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php
  2. Benni Mack marked it ready for review 10/04/21, 16:48

  3. core-ci voted on patch set 1 V -1 10/04/21, 16:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17578

  4. Stefan Bürk uploaded patch set 2 10/04/21, 17:39

  5. core-ci voted on patch set 2 V +1 10/04/21, 17:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17581

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/04/21, 17:52

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/04/21, 17:54

  8. Benni Mack merged patch set 3 10/04/21, 17:54