Review 10.4 Merged

71360Revert "[BUGFIX] Use correct variable in CheckboxElement"

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 10/08/21, 08:57

Commit message

This reverts commit d04a65b5a731fe67af06e0507627b198e8a96a7f.

Reason for revert: Breaks checkboxes in flexform, using "1"
as first item key instead of "0".

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/07/21, 22:21

  2. core-ci voted on patch set 1 V +1 10/07/21, 22:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17788

  3. Georg Ringer commented on patch set 1 10/08/21, 04:35

    Issue and releases lines are missing
  4. Oli Bartsch updated the commit message in patch set 2 10/08/21, 07:59

  5. Oli Bartsch commented on patch set 2 10/08/21, 07:59

    Reply

    Thanks, added them.
  6. core-ci voted on patch set 2 V +1 10/08/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17797

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/08/21, 08:57

  8. Benni Mack merged patch set 3 10/08/21, 08:57