Review 10.4 Merged

71361[BUGFIX] Catch UnknownLinkHandlerException in view helper

Benni Mack CR +2 V +2 Easy +2 −1 updated 10/08/21, 09:36

Commit message

EXT:redirect is using the TargetPageIdViewHelper to
get the page ID from a "t3://page?uid=" link. If this link
is however somehow malformed, e.g. "t3://page=uid=",
this previously lead to an exception being thrown, making
the redirects module unusable for an editor. Since an
editor usually does not have access to pid=0, it needed
an administrator to make the module accessible again.

This is now fixed by catching this exception in the
view helper.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 10/08/21, 08:11

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 10/08/21, 08:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17799

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/08/21, 09:35

  4. Benni Mack merged patch set 2 10/08/21, 09:36