Review main Merged

71373[BUGFIX] Properly handle TSconfig in content position maps

Oli Bartsch CR +2 V +2 Hard +400 −439 updated 10/04/21, 10:08

Commit message

The Core previously contained two classes for content
position maps. One of them was already decoupled from
the PagePositionMap class in #95331. The other still
extended this class while only some class variables
were used. However, both classes used nearly the same
code for the position map generation. Only the link
generation differs. Besides those derivation topics,
the columns to render where not always calculated
correctly, especially because TSconfig was not taken
into account.

Therefore this patch does the following:

* Adds a new abstract class with the main logic and
  lets the extending classes implement the abstract
  link generation methods
* The code for the page position map generation
  is refactored and heavily simplified
* The abstract class now takes care of determining
  all allowed columns by also respecting TSconfig.
  This means the calling code (MoveElementController
  and NewContentElementController) does no longer
  have to provide any colPos lists
* A JavaScript error, triggered by the "move content"
  links, is fixed

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 914

  1. Oli Bartsch uploaded patch set 1 09/29/21, 14:43

  2. Oli Bartsch uploaded patch set 2 09/29/21, 14:48

  3. core-ci voted on patch set 1 V +1 09/29/21, 14:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17315

  4. core-ci voted on patch set 2 V +1 09/29/21, 15:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17316

  5. Oli Bartsch rebased onto patch set 3 10/01/21, 11:07

  6. core-ci voted on patch set 3 V +1 10/01/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17409

  7. Oli Bartsch uploaded patch set 4 10/01/21, 14:01

  8. core-ci voted on patch set 4 V +1 10/01/21, 14:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17438

  9. Oli Bartsch updated the commit message in patch set 5 10/01/21, 15:46

  10. Benni Mack voted on patch set 5 V +1 CR +1 10/01/21, 16:01

  11. core-ci voted on patch set 5 V +1 10/01/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17451

  12. Jochen Roth voted on patch set 5 V +1 CR +1 10/04/21, 09:35

  13. Oli Bartsch voted on patch set 5 V +2 CR +2 10/04/21, 10:08

  14. Oli Bartsch merged patch set 6 10/04/21, 10:08