Review main Merged

71375[BUGFIX] Fix issues with drag uploader and empty file lists

Oli Bartsch CR +2 V +2 Hard +356 −113 updated 10/01/21, 17:37

Commit message

Previously, when a folder was empty or no files
were found for a search term, the filelist still
displayed the table header. This was related to
the Drag&Drop functionality, which internally
reads data from the table header.

However it's also sufficient to just hide the
table header and to show proper messages, including
direct actions, e.g. "reset search" or "upload files".

Therefore, also the Drag&Drop functionality is
improved. The draggable area now covers the whole
module, so the user does no longer have to strike
a 70 pixels box.

Besides, a couple of bugs in the Drag&Drop
implementation are fixed:

- When uploading files in "active search" mode, the
  file path is now properly added to the row
- After all files were uploaded, the user is now
  able to reload the module via a notification action
- Drag&Drop in FormEngine does no longer add the
  selector / checkbox field to the row
- When dragging files in and out of the dropzone,
  the dropzone is now hidden again after "dragleave"
  (only for filelist)
- The dropzone is now also hidden on "drop" (uploading
  the dragged files)
- The dropzone is not "activated" when not in the
  current visible scope (e.g. in another FormEngine tab)
- The checkbox is now also activated for uploaded
  files (without module reload)
- The full sized drozone can be closed with the ESC key
- JavaScript SyntaxError, triggered by a server error,
  such as "POST Content-Length" exceeds limit, is
  now properly handled

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2031

Show 36 earlier messages
  1. Oli Bartsch uploaded patch set 1 09/29/21, 23:41

  2. core-ci voted on patch set 1 V +1 09/29/21, 23:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17322

  3. Oli Bartsch uploaded patch set 2 10/01/21, 00:00

  4. Oli Bartsch uploaded patch set 3 10/01/21, 00:15

  5. core-ci voted on patch set 2 V -1 10/01/21, 00:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17378

  6. core-ci voted on patch set 3 V -1 10/01/21, 00:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17379

  1. Benni Mack updated the commit message in patch set 4 10/01/21, 07:50

  2. core-ci voted on patch set 4 V -1 10/01/21, 08:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17384

  3. Benjamin Franzke uploaded patch set 5 10/01/21, 10:18

  4. Oli Bartsch uploaded patch set 6 10/01/21, 10:38

  5. core-ci voted on patch set 6 V -1 10/01/21, 10:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17403

  6. core-ci voted on patch set 5 V -1 10/01/21, 10:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17399

  7. Oli Bartsch uploaded patch set 7 10/01/21, 10:53

  8. core-ci voted on patch set 7 V +1 10/01/21, 11:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17405

  9. Benni Mack voted on patch set 7 V +1 CR +1 10/01/21, 11:33

  10. Benjamin Franzke commented on patch set 7 10/01/21, 13:08

    Why I click "Upload Files" in an empty folder, and do not select a file, the drag-overlay keeps open. Can that be closed automatically (or not opened at all)? Or maybe at least closable by typing "escape" key?
  11. Andreas Kienast commented on patch set 7 V -1 10/01/21, 13:39

    If I have multiple FAL IRRE fields within the same tab, the upload is always applied to the last one. Additionally, the overlay remains, probably due to having multiple instances.
  12. Oli Bartsch commented on patch set 7 10/01/21, 13:49

    Reply

    Yes this was intended. The dropzone only closes automatically when it was opened automatically (by dragging sth. into the document). In case the user manually triggered the upload, the upload should also be manually closed. Otherwise this felt strange. However, I'm fine with adding an event listener for the ESC key, so users don't need to strike the close icon.

    Reply

    Yep, as discuessed in slack, the only possibility for now is to use the full sized dropzone only in filelist.
  13. Oli Bartsch uploaded patch set 8 10/01/21, 15:10

  14. Oli Bartsch uploaded patch set 9 10/01/21, 15:13

  15. Oli Bartsch commented on patch set 9 10/01/21, 15:14

    Reply

    Added the event listener for ESC

    Reply

    Done
  16. Oli Bartsch uploaded patch set 10 10/01/21, 15:16

  17. Andreas Kienast voted on patch set 10 V +1 CR +1 10/01/21, 15:18

  18. core-ci voted on patch set 8 V -1 10/01/21, 15:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17446

  19. core-ci voted on patch set 9 V +1 10/01/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17447

  20. core-ci voted on patch set 10 V +1 10/01/21, 15:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17448

  21. Oli Bartsch uploaded patch set 11 10/01/21, 16:21

  22. core-ci voted on patch set 11 V +1 10/01/21, 16:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17452

  23. Andreas Kienast voted on patch set 11 V +1 CR +1 10/01/21, 16:44

  24. Benjamin Franzke voted on patch set 11 V +2 CR +2 10/01/21, 17:37

  25. Benjamin Franzke merged patch set 12 10/01/21, 17:37