71375[BUGFIX] Fix issues with drag uploader and empty file lists
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 12
- Build/Sources/Sass/typo3/structure/_module_file_filelist.scssnew+84 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts+104 −16
- typo3/sysext/backend/Classes/Controller/File/FileController.php+5 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+3 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+12 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+2 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+18 −15
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+113 −79
Review log 2031
Show 36 earlier messages
-
Oli Bartsch uploaded patch set 1 09/29/21, 23:41
-
core-ci voted on patch set 1 V +1 09/29/21, 23:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17322
-
Oli Bartsch uploaded patch set 2 10/01/21, 00:00
-
Oli Bartsch uploaded patch set 3 10/01/21, 00:15
-
core-ci voted on patch set 2 V -1 10/01/21, 00:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17378
-
core-ci voted on patch set 3 V -1 10/01/21, 00:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17379
-
Benni Mack updated the commit message in patch set 4 10/01/21, 07:50
-
core-ci voted on patch set 4 V -1 10/01/21, 08:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17384
-
Benjamin Franzke uploaded patch set 5 10/01/21, 10:18
-
Oli Bartsch uploaded patch set 6 10/01/21, 10:38
-
core-ci voted on patch set 6 V -1 10/01/21, 10:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17403
-
core-ci voted on patch set 5 V -1 10/01/21, 10:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17399
-
Oli Bartsch uploaded patch set 7 10/01/21, 10:53
-
core-ci voted on patch set 7 V +1 10/01/21, 11:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17405
-
Benni Mack voted on patch set 7 V +1 CR +1 10/01/21, 11:33
-
Benjamin Franzke commented on patch set 7 10/01/21, 13:08
Why I click "Upload Files" in an empty folder, and do not select a file, the drag-overlay keeps open. Can that be closed automatically (or not opened at all)? Or maybe at least closable by typing "escape" key? -
Andreas Kienast commented on patch set 7 V -1 10/01/21, 13:39
If I have multiple FAL IRRE fields within the same tab, the upload is always applied to the last one. Additionally, the overlay remains, probably due to having multiple instances. -
Oli Bartsch commented on patch set 7 10/01/21, 13:49
Reply
Yes this was intended. The dropzone only closes automatically when it was opened automatically (by dragging sth. into the document). In case the user manually triggered the upload, the upload should also be manually closed. Otherwise this felt strange. However, I'm fine with adding an event listener for the ESC key, so users don't need to strike the close icon.Reply
Yep, as discuessed in slack, the only possibility for now is to use the full sized dropzone only in filelist. -
Oli Bartsch uploaded patch set 8 10/01/21, 15:10
-
Oli Bartsch uploaded patch set 9 10/01/21, 15:13
-
Oli Bartsch commented on patch set 9 10/01/21, 15:14
Reply
Added the event listener for ESCReply
Done -
Oli Bartsch uploaded patch set 10 10/01/21, 15:16
-
Andreas Kienast voted on patch set 10 V +1 CR +1 10/01/21, 15:18
-
core-ci voted on patch set 8 V -1 10/01/21, 15:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17446
-
core-ci voted on patch set 9 V +1 10/01/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17447
-
core-ci voted on patch set 10 V +1 10/01/21, 15:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17448
-
Oli Bartsch uploaded patch set 11 10/01/21, 16:21
-
core-ci voted on patch set 11 V +1 10/01/21, 16:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17452
-
Andreas Kienast voted on patch set 11 V +1 CR +1 10/01/21, 16:44
-
Benjamin Franzke voted on patch set 11 V +2 CR +2 10/01/21, 17:37
-
Benjamin Franzke merged patch set 12 10/01/21, 17:37