71376[TASK] Use DI for some Extbase core objects
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/extbase/Classes/Configuration/RequestHandlersConfigurationFactory.php+10 −30
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+0 −26
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerResolver.php+4 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+2 −3
- typo3/sysext/extbase/Classes/Persistence/ClassesConfiguration.php+0 −3
- typo3/sysext/extbase/Classes/Persistence/ClassesConfigurationFactory.php+10 −33
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+11 −34
- typo3/sysext/extbase/Classes/ServiceProvider.php+1 −1
- typo3/sysext/extbase/Configuration/Services.yaml+14 −0
- typo3/sysext/extbase/Tests/Functional/Configuration/RequestHandlerConfigurationFactoryTest.php+3 −1
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+9 −0
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+3 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/ClassesConfigurationFactoryTest.php+4 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+7 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+4 −8
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/ContainerTest.php+2 −1
Review log 1115
-
Helmut Hummel uploaded patch set 1 09/30/21, 10:36
-
core-ci voted on patch set 1 V -1 09/30/21, 10:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17329
-
Helmut Hummel uploaded patch set 2 09/30/21, 11:55
-
core-ci voted on patch set 2 V +1 09/30/21, 12:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17333
-
Benjamin Franzke voted on patch set 2 CR +1 09/30/21, 12:30
-
Benjamin Franzke uploaded patch set 3 09/30/21, 12:38
-
Benjamin Franzke wrote 09/30/21, 12:45
Topic set to di -
core-ci voted on patch set 3 V +1 09/30/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17334
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 09/30/21, 13:07
-
Benjamin Franzke commented on patch set 3 CR -1 09/30/21, 13:11
on it, I think I'd include ReflectionService as well. Will push a patchset soon. -
Benjamin Franzke uploaded patch set 4 09/30/21, 13:53
-
core-ci voted on patch set 4 V +1 09/30/21, 14:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17340
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 09/30/21, 14:26
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 09/30/21, 14:37
-
Benjamin Franzke merged patch set 5 09/30/21, 14:37