Review main Merged

71376[TASK] Use DI for some Extbase core objects

Helmut Hummel CR +2 V +2 Normal +91 −156 updated 09/30/21, 14:37

Commit message

With Symfony DI we can simplify our code
and remove workarounds previously introduced to
prepare singleton objects for later injection.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1115

  1. Helmut Hummel uploaded patch set 1 09/30/21, 10:36

  2. core-ci voted on patch set 1 V -1 09/30/21, 10:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17329

  3. Helmut Hummel uploaded patch set 2 09/30/21, 11:55

  4. core-ci voted on patch set 2 V +1 09/30/21, 12:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17333

  5. Benjamin Franzke voted on patch set 2 CR +1 09/30/21, 12:30

  6. Benjamin Franzke uploaded patch set 3 09/30/21, 12:38

  7. Benjamin Franzke wrote 09/30/21, 12:45

    Topic set to di
  8. core-ci voted on patch set 3 V +1 09/30/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17334

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 09/30/21, 13:07

  10. Benjamin Franzke commented on patch set 3 CR -1 09/30/21, 13:11

    on it, I think I'd include ReflectionService as well. Will push a patchset soon.
  11. Benjamin Franzke uploaded patch set 4 09/30/21, 13:53

  12. core-ci voted on patch set 4 V +1 09/30/21, 14:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17340

  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 09/30/21, 14:26

  14. Benjamin Franzke voted on patch set 4 V +2 CR +2 09/30/21, 14:37

  15. Benjamin Franzke merged patch set 5 09/30/21, 14:37