Review main Merged

71379[BUGFIX] Check Notification action prior to execution

Oli Bartsch CR +2 V +2 Easy +6 −4 updated 09/30/21, 14:04

Commit message

The Notification JavaScript module previously
failed to check a given action before executing
it. This is now fixed with an "instance of" check.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 09/30/21, 13:02

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/30/21, 13:03

  3. core-ci voted on patch set 1 V +1 09/30/21, 13:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17337

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/30/21, 14:04

  5. Benni Mack merged patch set 2 09/30/21, 14:04