71380[TASK] Centralize Backend Redirects for Backend Routing
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/BackendController.php4+20 −19
- typo3/sysext/backend/Classes/Controller/LoginController.php+7 −6
- typo3/sysext/backend/Classes/Controller/MfaController.php+7 −6
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+6 −5
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+6 −5
- typo3/sysext/backend/Classes/Http/RequestHandler.php+4 −4
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+2 −2
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+3 −3
- typo3/sysext/backend/Classes/Routing/Exception/RouteTypeNotAllowedException.phpnew+27 −0
- typo3/sysext/backend/Classes/Routing/RouteRedirect.phpnew+137 −0
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+14 −38
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+10 −10
- typo3/sysext/install/Classes/Controller/InstallerController.php+9 −6
Review log 1115
-
Benni Mack uploaded patch set 1 09/30/21, 13:46
-
Benni Mack uploaded patch set 2 09/30/21, 14:02
-
core-ci voted on patch set 1 V -1 09/30/21, 14:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17339
-
core-ci voted on patch set 2 V -1 09/30/21, 14:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17342
-
Oli Bartsch uploaded patch set 3 09/30/21, 15:21
-
core-ci voted on patch set 3 V +1 09/30/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17357
-
Benni Mack uploaded patch set 4 10/01/21, 09:04
-
core-ci voted on patch set 4 V +1 10/01/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17389
-
Oliver Hader commented on patch set 4 10/01/21, 10:42
-
Benni Mack commented on patch set 4 10/01/21, 10:48
BackendController.php:391Replyyes. but the finally has the if(!$startModule) -
Oli Bartsch voted on patch set 4 V +1 CR +1 10/01/21, 11:06
-
Oliver Hader commented on patch set 4 V +1 CR +1 10/01/21, 11:14
BackendController.php:391ReplyOkay... "silent failure" -
Benni Mack voted on patch set 4 V +2 CR +2 10/01/21, 11:19
-
Benni Mack merged patch set 5 10/01/21, 11:19
-
Benni Mack commented on patch set 5 10/01/21, 11:19
BackendController.php:391ReplyDone
BackendController.php:391