Review main Merged

71380[TASK] Centralize Backend Redirects for Backend Routing

Benni Mack CR +2 V +2 Hard +252 −104 updated 10/01/21, 11:19

Commit message

The internal logic to create backend links with a redirect

The internal method "UriBuilder->buildUriWithRedirectFromRequest()"
is removed, and a new RouteRedirect object is now added which
cleans up the Routes and Parameters and does various checks
in a central place.

The method "UriBuilder->buildUriWithRedirect()" now needs
a RedirectRoute object to build the proper URI.

The BackendController also checks now properly via the RouteRedirect.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1115

  1. Benni Mack uploaded patch set 1 09/30/21, 13:46

  2. Benni Mack uploaded patch set 2 09/30/21, 14:02

  3. core-ci voted on patch set 1 V -1 09/30/21, 14:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17339

  4. core-ci voted on patch set 2 V -1 09/30/21, 14:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17342

  5. Oli Bartsch uploaded patch set 3 09/30/21, 15:21

  6. core-ci voted on patch set 3 V +1 09/30/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17357

  7. Benni Mack uploaded patch set 4 10/01/21, 09:04

  8. core-ci voted on patch set 4 V +1 10/01/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17389

  9. Oliver Hader commented on patch set 4 10/01/21, 10:42

    BackendController.php:391

    Not sure if that is the expected behavior... `finally` is always executed, even if there is a valid redirect...
  10. Benni Mack commented on patch set 4 10/01/21, 10:48

    BackendController.php:391 Reply

    yes. but the finally has the if(!$startModule)
  11. Oli Bartsch voted on patch set 4 V +1 CR +1 10/01/21, 11:06

  12. Oliver Hader commented on patch set 4 V +1 CR +1 10/01/21, 11:14

    BackendController.php:391 Reply

    Okay... "silent failure"
  13. Benni Mack voted on patch set 4 V +2 CR +2 10/01/21, 11:19

  14. Benni Mack merged patch set 5 10/01/21, 11:19

  15. Benni Mack commented on patch set 5 10/01/21, 11:19

    BackendController.php:391 Reply

    Done