Review main Merged

71382[BUGFIX] Fix the generics annotations for ObjectManager(Interface)

Oliver Klee CR +2 V +2 Normal +37 −24 updated 10/04/21, 11:39

Commit message

To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interface) generics need to
be on the generating methods, not on the class/interface itself.

Also streamline the PHPDoc to be more consistent, and fix the semantics
(there are no object instances, only class instances) to avoid
confusing the reader.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Oliver Klee uploaded patch set 1 09/30/21, 14:33

  2. Oliver Klee uploaded patch set 2 09/30/21, 14:51

  3. core-ci voted on patch set 1 V -1 09/30/21, 14:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17346

  4. Oliver Klee uploaded patch set 3 09/30/21, 15:01

  5. core-ci voted on patch set 2 V -1 09/30/21, 15:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17352

  6. core-ci voted on patch set 3 V +1 09/30/21, 15:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17354

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/30/21, 16:52

  8. Nikita Hovratov commented on patch set 3 09/30/21, 19:16

    TYPO3 9.5 is on ELTS mode now.
  9. Oliver Klee updated the commit message in patch set 4 09/30/21, 20:02

  10. Oliver Klee commented on patch set 3 09/30/21, 20:02

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 09/30/21, 20:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17374

  12. Andreas Kienast voted on patch set 4 V +1 CR +1 10/01/21, 06:38

  13. Simon Gilli voted on patch set 4 V +1 CR +1 10/04/21, 09:29

  14. Wouter Wolters voted on patch set 4 V +1 CR +1 10/04/21, 09:33

  15. Guido Schmechel voted on patch set 4 CR +1 10/04/21, 09:46

  16. Andreas Kienast voted on patch set 4 V +2 CR +2 10/04/21, 11:39

  17. Andreas Kienast merged patch set 5 10/04/21, 11:39