Review main Merged

71383[TASK] Use PSR-7 Request information in linkvalidator

Benni Mack CR +2 V +2 Normal +22 −41 updated 10/01/21, 12:19

Commit message

This change reduces the usages of GeneralUtility::_GP()
by using the PSR-7 ServerRequestInterface input.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Benni Mack uploaded patch set 1 09/30/21, 14:39

  2. core-ci voted on patch set 1 V +1 09/30/21, 15:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17348

  3. Nikita Hovratov uploaded patch set 2 10/01/21, 10:25

  4. Nikita Hovratov commented on patch set 2 10/01/21, 10:34

    LinkValidatorReport.php:275

    AFAICS this "showalllinks" parameter is not provided anywhere. Probably some ancient leftover. Can we get rid off this (in another patch probably)?
  5. core-ci voted on patch set 2 V +1 10/01/21, 10:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17400

  6. Benni Mack commented on patch set 2 10/01/21, 10:43

    LinkValidatorReport.php:275 Reply

    let's remove it right away.
  7. Benni Mack uploaded patch set 3 10/01/21, 10:45

  8. core-ci voted on patch set 3 V +1 10/01/21, 11:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17404

  9. Nikita Hovratov commented on patch set 3 10/01/21, 11:21

    LinkValidatorReport.php:275 Reply

    Done
  10. Nikita Hovratov uploaded patch set 4 10/01/21, 11:24

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/01/21, 11:26

  12. core-ci voted on patch set 4 V +1 10/01/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17412

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 10/01/21, 12:19

  14. Oli Bartsch merged patch set 5 10/01/21, 12:19