Review main Merged

71387[BUGFIX] Delete orphans that are deleted or hidden

Alexander Stehlik CR +2 V +2 Easy +8 −7 updated 11/03/21, 15:25

Commit message

All restrictions are removed from the query builder that
fetches the orphan records.

A seperate query builder instance is used to execute the count
query to check if there are any orphans for a table.

The records are only fetched if there are any.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Alexander Stehlik uploaded patch set 1 09/30/21, 16:13

  2. Alexander Stehlik updated the commit message in patch set 2 09/30/21, 16:14

  3. core-ci voted on patch set 1 V +1 09/30/21, 16:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17358

  4. core-ci voted on patch set 2 V +1 09/30/21, 16:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17359

  5. Benni Mack commented on patch set 2 10/01/21, 13:34

    9.5 is EOL for us
  6. Alexander Stehlik updated the commit message in patch set 3 10/01/21, 13:54

  7. Alexander Stehlik commented on patch set 3 10/01/21, 13:55

    Reply

    Ah, right, I was not sure about that. I removed it from the list :)
  8. core-ci voted on patch set 3 V +1 10/01/21, 14:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17437

  9. Benni Mack voted on patch set 3 CR +1 10/15/21, 09:02

  10. Guido Schmechel voted on patch set 3 CR +1 10/18/21, 08:43

  11. Wouter Wolters voted on patch set 3 CR +1 10/18/21, 09:21

  12. Christian Kuhn commented on patch set 3 10/19/21, 14:30

    Quite frankly, I'm simply not sure here: The strategy and logic that command follows is hilarious and has probably never been reviewed properly since kaspers first introduction. The mess starts with the fact that the entire db uid's are fetched into a single monster array, and everything operates on it. I somehow feel I can't really estimate the impact of this change without rewriting the entire thing first.
  13. Christian Kuhn voted on patch set 3 V +1 11/03/21, 15:25

  14. Benni Mack voted on patch set 3 V +2 CR +2 11/03/21, 15:25

  15. Benni Mack merged patch set 4 11/03/21, 15:25