71395[BUGFIX] Fix PageRenderer->addRequireJsConfiguration from ext_localconf
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 4
Files 4
Review log 1419
-
Benjamin Franzke uploaded patch set 1 09/30/21, 22:04
-
core-ci voted on patch set 1 V -1 09/30/21, 22:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17377
-
Benjamin Franzke uploaded patch set 2 10/01/21, 04:26
-
core-ci voted on patch set 2 V +1 10/01/21, 04:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17383
-
Christian Kuhn commented on patch set 2 10/01/21, 08:30
I'm not convinced here: General core strategy is to phase out ext_*. The hook usages work for our 2 extensions, I think we should use them and shouldn't foster ext_* usages here. What do you think? -
Benjamin Franzke commented on patch set 2 10/01/21, 08:36
Reply
Yea, fully agree on that. Though I think we still we need provide a way that works as in v10, if we don't have a proper new one. (which we can't add right now, due to feature freeze) I think we should provide a proper way in v12 using an event, but for now – if we are honest – we don't have *the* proper way (besides ext_localconf) to register requireJS configuration. -
Christian Kuhn commented on patch set 2 10/01/21, 08:52
Reply
Sure. We could still keep the hooks in v11 for the two extensions and change that to events in v12, right? The two usages would be a good use case for how-to change them to events in v12, then. I don't insist on this, just a thought ... If you prefer to look back to v10 in this area than to look forward to v12, I'll not block it, just asking if it's worth to change the two hooks to ext_* registration with this patch again. -
Benjamin Franzke uploaded patch set 3 10/01/21, 09:14
-
Benjamin Franzke commented on patch set 3 10/01/21, 09:14
Reply
Ok, well, we can leave the hooks for core if we agree to add an event in v12, I'm fine with that. :+1: Done. -
core-ci voted on patch set 3 V +1 10/01/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17391
-
Christian Kuhn updated the commit message in patch set 4 10/01/21, 09:37
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/21, 09:38
-
core-ci voted on patch set 4 V +1 10/01/21, 09:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17395
-
Anja Leichsenring updated the commit message in patch set 5 10/01/21, 12:37
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/01/21, 12:37
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 10/01/21, 12:40
-
core-ci voted on patch set 5 V +1 10/01/21, 12:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17424
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 10/01/21, 12:59
-
Benjamin Franzke merged patch set 6 10/01/21, 13:00