Review main Merged

71397[BUGFIX] Fix immutability of custom extbase Request->with*() methods

Benjamin Franzke CR +2 V +2 Normal +28 −28 updated 10/01/21, 12:03

Commit message

While a cloned request was returned, the extbase
attribute was shared between old and new request,
rendering the old and the new (cloned) request 100% equal,
with*() methods need to be immutable instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Benjamin Franzke uploaded patch set 1 10/01/21, 08:56

  2. Benjamin Franzke updated the commit message in patch set 2 10/01/21, 09:02

  3. core-ci voted on patch set 2 V -1 10/01/21, 09:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17388

  4. Benjamin Franzke uploaded patch set 3 10/01/21, 09:19

  5. core-ci voted on patch set 3 V +1 10/01/21, 09:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17392

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 10/01/21, 09:42

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/01/21, 12:03

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 10/01/21, 12:03

  9. Christian Kuhn merged patch set 4 10/01/21, 12:03