Review main Merged

71398[TASK] Use route objects for Backend Routing where possible

Benni Mack CR +2 V +2 Easy +12 −12 updated 10/04/21, 15:32

Commit message

Due to the logic of not using QueryParams[route]
anymore, but having deeplinks, more TYPO3-core
code now uses UriBuilder->buildUriFromRoute()
instead of UriBuilder->buildUriFromRoutePath()

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Benni Mack uploaded patch set 1 10/01/21, 09:25

  2. core-ci voted on patch set 1 V -1 10/01/21, 09:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17393

  3. Benni Mack uploaded patch set 2 10/01/21, 13:33

  4. core-ci voted on patch set 2 V +1 10/01/21, 14:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17436

  5. Benni Mack updated the commit message in patch set 3 10/03/21, 14:43

  6. core-ci voted on patch set 3 V +1 10/03/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17513

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 10/04/21, 14:23

  8. Benjamin Franzke voted on patch set 3 CR +1 10/04/21, 14:29

  9. Benjamin Franzke uploaded patch set 4 10/04/21, 14:39

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 10/04/21, 14:44

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/04/21, 14:46

  12. core-ci voted on patch set 4 V -1 10/04/21, 15:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17565

  13. Benjamin Franzke commented on patch set 4 V -1 10/04/21, 15:10

    > Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17565 Ok, fails because the tests do nto have the route option set. Now, if I set it with: diff --git a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php index e0dc3b493d..61b0270531 100644 --- a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php +++ b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php @@ -58,7 +58,7 @@ abstract class AbstractImportExportTestCase extends FunctionalTestCase Bootstrap::initializeLanguageObject(); $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest('https://www.example.com/';)) - ->withAttribute('route', new Route('/record/importexport/export', [])) + ->withAttribute('route', new Route('/record/importexport/export', ['_identifier' => 'tx_impexp_export'])) ->withAttribute('applicationType', SystemEnvironmentBuilder::REQUESTTYPE_BE) ->withAttribute('normalizedParams', new NormalizedParams([], [], '', '')); } Then tests fail deeply in testing framework: diff --git a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php index e0dc3b493d..61b0270531 100644 --- a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php +++ b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php @@ -58,7 +58,7 @@ abstract class AbstractImportExportTestCase extends FunctionalTestCase Bootstrap::initializeLanguageObject(); $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest('https://www.example.com/';)) - ->withAttribute('route', new Route('/record/importexport/export', [])) + ->withAttribute('route', new Route('/record/importexport/export', ['_identifier' => 'tx_impexp_export'])) ->withAttribute('applicationType', SystemEnvironmentBuilder::REQUESTTYPE_BE) ->withAttribute('normalizedParams', new NormalizedParams([], [], '', '')); } Likely because the route option triggered a new codepath in the user authentication. THEREFORE I revert back to patchset 3.
  14. Benjamin Franzke uploaded patch set 5 10/04/21, 15:11

  15. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/04/21, 15:15

  16. Oli Bartsch voted on patch set 5 V +1 CR +1 10/04/21, 15:22

  17. core-ci voted on patch set 5 V +1 10/04/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17569

  18. Benjamin Franzke voted on patch set 5 V +2 CR +2 10/04/21, 15:32

  19. Benjamin Franzke merged patch set 6 10/04/21, 15:32