71398[TASK] Use route objects for Backend Routing where possible
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −4
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
Review log 1419
-
Benni Mack uploaded patch set 1 10/01/21, 09:25
-
core-ci voted on patch set 1 V -1 10/01/21, 09:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17393
-
Benni Mack uploaded patch set 2 10/01/21, 13:33
-
core-ci voted on patch set 2 V +1 10/01/21, 14:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17436
-
Benni Mack updated the commit message in patch set 3 10/03/21, 14:43
-
core-ci voted on patch set 3 V +1 10/03/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17513
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 10/04/21, 14:23
-
Benjamin Franzke voted on patch set 3 CR +1 10/04/21, 14:29
-
Benjamin Franzke uploaded patch set 4 10/04/21, 14:39
-
Oli Bartsch voted on patch set 4 V +1 CR +1 10/04/21, 14:44
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/04/21, 14:46
-
core-ci voted on patch set 4 V -1 10/04/21, 15:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17565
-
Benjamin Franzke commented on patch set 4 V -1 10/04/21, 15:10
> Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17565 Ok, fails because the tests do nto have the route option set. Now, if I set it with: diff --git a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php index e0dc3b493d..61b0270531 100644 --- a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php +++ b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php @@ -58,7 +58,7 @@ abstract class AbstractImportExportTestCase extends FunctionalTestCase Bootstrap::initializeLanguageObject(); $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest('https://www.example.com/';)) - ->withAttribute('route', new Route('/record/importexport/export', [])) + ->withAttribute('route', new Route('/record/importexport/export', ['_identifier' => 'tx_impexp_export'])) ->withAttribute('applicationType', SystemEnvironmentBuilder::REQUESTTYPE_BE) ->withAttribute('normalizedParams', new NormalizedParams([], [], '', '')); } Then tests fail deeply in testing framework: diff --git a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php index e0dc3b493d..61b0270531 100644 --- a/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php +++ b/typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php @@ -58,7 +58,7 @@ abstract class AbstractImportExportTestCase extends FunctionalTestCase Bootstrap::initializeLanguageObject(); $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest('https://www.example.com/';)) - ->withAttribute('route', new Route('/record/importexport/export', [])) + ->withAttribute('route', new Route('/record/importexport/export', ['_identifier' => 'tx_impexp_export'])) ->withAttribute('applicationType', SystemEnvironmentBuilder::REQUESTTYPE_BE) ->withAttribute('normalizedParams', new NormalizedParams([], [], '', '')); } Likely because the route option triggered a new codepath in the user authentication. THEREFORE I revert back to patchset 3. -
Benjamin Franzke uploaded patch set 5 10/04/21, 15:11
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/04/21, 15:15
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/04/21, 15:22
-
core-ci voted on patch set 5 V +1 10/04/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17569
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 10/04/21, 15:32
-
Benjamin Franzke merged patch set 6 10/04/21, 15:32