Review 10.4 Merged

71399[TASK] Revert "[TASK] Add EventDispatcher to symfony console application"

Benjamin Franzke CR +2 V +2 Easy +3 −9 updated 10/01/21, 12:25

Commit message

EventDispatcher injection via symfony contracts interface is
possible only as of symfony/console v5.0 – got fixed in:
https://github.com/symfony/symfony/commit/5ccb472623666276

TYPO3 v10 needs to be symfony v4 compatible, thus
commit b26e24c49ada65e52c06805db4c1109eff785ca7 is reverted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Benjamin Franzke uploaded patch set 1 10/01/21, 09:55

  2. core-ci voted on patch set 1 V +1 10/01/21, 10:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17397

  3. Christian Kuhn commented on patch set 1 CR +1 10/01/21, 10:09

    fine with the revert of a merge from yesterday. good to do stuff like that quickly if needed.
  4. Christian Kuhn voted on patch set 1 V +1 10/01/21, 12:10

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/01/21, 12:10

  6. Anja Leichsenring updated the commit message in patch set 2 10/01/21, 12:12

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/01/21, 12:12

  8. core-ci voted on patch set 2 V +1 10/01/21, 12:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17417

  9. Benni Mack voted on patch set 2 V +2 CR +2 10/01/21, 12:25

  10. Benni Mack merged patch set 3 10/01/21, 12:25