71402[BUGFIX] Resolve shortcuts in typolink directly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php2+6 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+2 −35
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+51 −28
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+9 −9
Review log 2132
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 10/01/21, 12:51
-
core-ci voted on patch set 1 V -1 10/01/21, 13:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17426
-
Benni Mack rebased onto patch set 2 10/08/21, 08:59
-
core-ci voted on patch set 2 V -1 10/08/21, 09:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17803
-
Benni Mack wrote 11/29/21, 10:12
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 3 11/29/21, 13:36
-
core-ci voted on patch set 3 V -1 11/29/21, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20050
-
Benni Mack updated the commit message in patch set 4 12/01/21, 08:02
-
core-ci voted on patch set 4 V -1 12/01/21, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20289
-
Benni Mack uploaded patch set 5 12/01/21, 08:51
-
core-ci voted on patch set 5 V +1 12/01/21, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20294
-
Benni Mack uploaded patch set 6 12/01/21, 10:02
-
core-ci voted on patch set 6 V -1 12/01/21, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20297
-
Benni Mack uploaded patch set 7 12/01/21, 13:17
-
core-ci voted on patch set 7 V -1 12/01/21, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20315
-
Benni Mack uploaded patch set 8 12/20/21, 16:18
-
core-ci voted on patch set 8 V +1 12/20/21, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21308
-
Stefan Bürk commented on patch set 9 12/20/21, 16:57
Published edit on patch set 8. -
Stefan Bürk commented on patch set 10 12/20/21, 16:57
Published edit on patch set 9. -
core-ci voted on patch set 9 V -1 12/20/21, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21312
-
core-ci voted on patch set 10 V +1 12/20/21, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21313
-
Stefan Bürk voted on patch set 10 V +1 CR +1 12/20/21, 20:31
-
Oli Bartsch commented on patch set 10 12/20/21, 21:28
PageRepository.php:981This should IMO return an empty array. While the return annotation is mixed, looking at the code the return type will always be array (as $page is filled with either ->getPage() or ->getMenu(), which both define array as return type). Additionally calling code like TSFE expects the return to be an array as can be seen on the corresponding class variable. Another example is TSFE->checkTranslatedShortcut(), where return FALSE will most likely lead to an undefined index warning since $shortcut['uid'] is called on the result. -
Stefan Bürk wrote 12/21/21, 07:04
Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech> -
Stefan Bürk wrote 12/21/21, 07:04
Removed Verified+1 by Stefan Bürk <stefan@buerk.tech> -
Benni Mack uploaded patch set 11 12/21/21, 08:05
-
core-ci voted on patch set 11 V +1 12/21/21, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21334
-
Benni Mack commented on patch set 11 12/21/21, 08:24
PageRepository.php:981ReplyDone -
Oli Bartsch voted on patch set 11 V +1 CR +1 12/21/21, 09:30
-
Christian Kuhn voted on patch set 11 V +1 CR +1 12/21/21, 09:33
-
Benni Mack voted on patch set 11 V +2 CR +2 12/21/21, 10:08
-
Benni Mack merged patch set 12 12/21/21, 10:08