Review main Merged

71402[BUGFIX] Resolve shortcuts in typolink directly

Benni Mack CR +2 V +2 Normal +68 −74 updated 12/21/21, 10:08

Commit message

Currently, HMENU generates the direct destination for
a shortcut URL, but typolink does not. This is an
inconsistency, and since HMENU is actually using typolink
now as well (in 4.x this was different), the resolving
of shortcuts can now be moved into the typolink/link building
functionality.

Page Shortcuts are now resolved (recursively!) at a single point for
all links, except for RANDOM_SUBPAGE variants, as this is sorted
out during runtime when hitting the RANDOM_SUBPAGE shortcut page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 2132

Show 47 earlier messages
  1. Benni Mack uploaded patch set 1 10/01/21, 12:51

  2. core-ci voted on patch set 1 V -1 10/01/21, 13:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17426

  3. Benni Mack rebased onto patch set 2 10/08/21, 08:59

  4. core-ci voted on patch set 2 V -1 10/08/21, 09:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17803

  5. Benni Mack wrote 11/29/21, 10:12

    Change destination moved from master to main
  6. Benni Mack updated the commit message in patch set 3 11/29/21, 13:36

  7. core-ci voted on patch set 3 V -1 11/29/21, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20050

  1. Benni Mack updated the commit message in patch set 4 12/01/21, 08:02

  2. core-ci voted on patch set 4 V -1 12/01/21, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20289

  3. Benni Mack uploaded patch set 5 12/01/21, 08:51

  4. core-ci voted on patch set 5 V +1 12/01/21, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20294

  5. Benni Mack uploaded patch set 6 12/01/21, 10:02

  6. core-ci voted on patch set 6 V -1 12/01/21, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20297

  7. Benni Mack uploaded patch set 7 12/01/21, 13:17

  8. core-ci voted on patch set 7 V -1 12/01/21, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20315

  9. Benni Mack uploaded patch set 8 12/20/21, 16:18

  10. core-ci voted on patch set 8 V +1 12/20/21, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21308

  11. Stefan Bürk commented on patch set 9 12/20/21, 16:57

    Published edit on patch set 8.
  12. Stefan Bürk commented on patch set 10 12/20/21, 16:57

    Published edit on patch set 9.
  13. core-ci voted on patch set 9 V -1 12/20/21, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21312

  14. core-ci voted on patch set 10 V +1 12/20/21, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21313

  15. Stefan Bürk voted on patch set 10 V +1 CR +1 12/20/21, 20:31

  16. Oli Bartsch commented on patch set 10 12/20/21, 21:28

    PageRepository.php:981

    This should IMO return an empty array. While the return annotation is mixed, looking at the code the return type will always be array (as $page is filled with either ->getPage() or ->getMenu(), which both define array as return type). Additionally calling code like TSFE expects the return to be an array as can be seen on the corresponding class variable. Another example is TSFE->checkTranslatedShortcut(), where return FALSE will most likely lead to an undefined index warning since $shortcut['uid'] is called on the result.
  17. Stefan Bürk wrote 12/21/21, 07:04

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  18. Stefan Bürk wrote 12/21/21, 07:04

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  19. Benni Mack uploaded patch set 11 12/21/21, 08:05

  20. core-ci voted on patch set 11 V +1 12/21/21, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21334

  21. Benni Mack commented on patch set 11 12/21/21, 08:24

    PageRepository.php:981 Reply

    Done
  22. Oli Bartsch voted on patch set 11 V +1 CR +1 12/21/21, 09:30

  23. Christian Kuhn voted on patch set 11 V +1 CR +1 12/21/21, 09:33

  24. Benni Mack voted on patch set 11 V +2 CR +2 12/21/21, 10:08

  25. Benni Mack merged patch set 12 12/21/21, 10:08