71404[BUGFIX] Reduce DB queries for HMENU with external URLs
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1011
-
Benni Mack uploaded patch set 1 10/01/21, 13:24
-
core-ci voted on patch set 1 V +1 10/01/21, 13:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17432
-
Andreas Kienast voted on patch set 1 CR +1 10/01/21, 13:52
-
Andreas Kienast commented on patch set 1 10/01/21, 13:53
How do you find these things? -
Benni Mack commented on patch set 1 10/03/21, 14:32
Actually, it's not always an additional DB query, but for sure a duplicate code execution.Reply
browsing through the source code :D In general, there a bunch of issues/bugs related to HMENU and typolink. typolink() and HMENU link generation were much different in v4, but get closer more and more, and this is one of the things which is still a leftover from the derivative. Since I was involved in the splitting up of typolink() into custom "LinkHandler" I come back to this class every once in a while and see how things went. Unfortunately we only have a few tests for HMENU, but a great deal of typolink() functional tests. -
Wouter Wolters voted on patch set 1 CR +1 10/04/21, 17:43
-
Andreas Kienast voted on patch set 1 V +1 10/04/21, 21:16
-
Nikita Hovratov commented on patch set 1 10/05/21, 06:53
AbstractMenuContentObject.php:1293Don't know if this is important, but E-Mail links won't get their target removed anymore. It's probably fine though. -
Nikita Hovratov voted on patch set 1 V +1 CR +1 10/05/21, 06:54
-
Benni Mack commented on patch set 1 V +2 CR +2 10/05/21, 07:03
AbstractMenuContentObject.php:1293Replyyes. the email links should get their target properly removed in the Email Link Builder -
Benni Mack merged patch set 2 10/05/21, 07:03