Review main Merged

71406[TASK] Always resolve static resources URIs with new API

Helmut Hummel CR +2 V +2 Normal +58 −78 updated 10/04/21, 13:16

Commit message

Instead of relying on either hard coded values
or using API, which implicitly calculates URIs
from absolute paths, the recently introduced
method is used to resolve URIs from extension
paths.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1421

  1. Helmut Hummel uploaded patch set 1 10/01/21, 15:09

  2. core-ci voted on patch set 1 V -1 10/01/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17444

  3. Helmut Hummel rebased onto patch set 2 10/01/21, 22:47

  4. core-ci voted on patch set 2 V -1 10/01/21, 22:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17464

  5. Helmut Hummel uploaded patch set 3 10/01/21, 23:10

  6. core-ci voted on patch set 3 V +1 10/01/21, 23:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17470

  7. Helmut Hummel rebased onto patch set 4 10/02/21, 17:09

  8. core-ci voted on patch set 4 V +1 10/02/21, 17:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17493

  9. Simon Gilli updated the commit message in patch set 5 10/02/21, 18:33

  10. Simon Gilli voted on patch set 5 V +1 CR +1 10/02/21, 18:33

  11. core-ci voted on patch set 5 V +1 10/02/21, 18:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17495

  12. Helmut Hummel uploaded patch set 6 10/03/21, 08:19

  13. core-ci voted on patch set 6 V +1 10/03/21, 08:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17502

  14. Simon Gilli commented on patch set 6 V +1 CR +1 10/03/21, 16:12

    This patch was part of my extensive tests of https://review.typo3.org/c/Packages/TYPO3.CMS/+/71407.
  15. Benni Mack commented on patch set 6 CR +1 10/03/21, 16:58

    ResourceViewHelper.php:89

    finally we can get rid of this hack.
  16. Helmut Hummel rebased onto patch set 7 10/03/21, 17:42

  17. Helmut Hummel commented on patch set 7 10/03/21, 17:44

    ResourceViewHelper.php:89 Reply

    Ack
  18. core-ci voted on patch set 7 V +1 10/03/21, 18:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17519

  19. Simon Gilli voted on patch set 7 V +1 CR +1 10/03/21, 19:33

  20. Benni Mack voted on patch set 7 V +2 CR +2 10/04/21, 13:16

  21. Benni Mack merged patch set 8 10/04/21, 13:16