71407[BUGFIX] Properly calculate web path for composer packages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Gilli +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Gilli +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/core/Classes/Composer/InstallerScripts.php+7 −6
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php+20 −0
- typo3/sysext/core/Classes/Package/ComposerDeficitDetector.php+3 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+2 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/Resource/StorageRepository.php1+3 −3
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −4
- typo3/sysext/core/Classes/Utility/PathUtility.php+39 −18
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.php+4 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest/Fixtures/Resources/Public/charset.cssrenamed+0 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+18 −18
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+12 −3
- typo3/sysext/form/Classes/SoftReference/FormPersistenceIdentifierSoftReferenceParser.php+21 −2
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+3 −0
- typo3/sysext/reports/Classes/Controller/ReportController.php+6 −5
- typo3/sysext/reports/Resources/Private/Templates/Report/Index.html+1 −1
- phpstan.neon+1 −1
Review log 2440
Show 815 earlier messages
-
Helmut Hummel uploaded patch set 1 10/01/21, 15:09
-
core-ci voted on patch set 1 V -1 10/01/21, 15:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17445
-
Helmut Hummel rebased onto patch set 2 10/01/21, 22:47
-
core-ci voted on patch set 2 V -1 10/01/21, 22:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17465
-
Helmut Hummel uploaded patch set 3 10/01/21, 23:10
-
core-ci voted on patch set 3 V -1 10/01/21, 23:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17471
-
Helmut Hummel uploaded patch set 4 10/02/21, 17:09
-
core-ci voted on patch set 4 V -1 10/02/21, 17:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17494
-
Helmut Hummel uploaded patch set 5 10/02/21, 18:47
-
core-ci voted on patch set 5 V -1 10/02/21, 18:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17496
-
Helmut Hummel uploaded patch set 6 10/03/21, 07:31
-
core-ci voted on patch set 6 V -1 10/03/21, 07:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17500
-
Helmut Hummel uploaded patch set 7 10/03/21, 08:12
-
core-ci voted on patch set 7 V -1 10/03/21, 08:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17501
-
Helmut Hummel uploaded patch set 8 10/03/21, 08:19
-
Helmut Hummel uploaded patch set 9 10/03/21, 08:21
-
core-ci voted on patch set 8 V -1 10/03/21, 08:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17503
-
core-ci voted on patch set 9 V +1 10/03/21, 08:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17504
-
Helmut Hummel uploaded patch set 10 10/03/21, 09:14
-
Helmut Hummel uploaded patch set 11 10/03/21, 09:33
-
core-ci voted on patch set 10 V +1 10/03/21, 09:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17505
-
core-ci voted on patch set 11 V +1 10/03/21, 09:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17506
-
Helmut Hummel uploaded patch set 12 10/03/21, 12:41
-
core-ci voted on patch set 12 V -1 10/03/21, 12:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17507
-
Helmut Hummel uploaded patch set 13 10/03/21, 13:33
-
core-ci voted on patch set 13 V +1 10/03/21, 13:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17508
-
Helmut Hummel uploaded patch set 14 10/03/21, 14:03
-
core-ci voted on patch set 14 V +1 10/03/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17510
-
Simon Gilli commented on patch set 14 V -1 10/03/21, 14:30
On it. Still need to test some parts but most should work fine in the meantime. -
Simon Gilli commented on patch set 14 V +1 CR +1 10/03/21, 16:10
After two days of testing finally everything works and I'm not able to find more bugs. I did some really extensive tests using the introduction and bootstrap package. The first testing scenario was with the extensions installed in typo3/sysext and typo3conf/ext (Composer legacy install). For the second tests I've used a modified cms-composer-installers package where all packages were installed in the vendor folder (Composer compliant install). Thanks Helmut for this great patch which makes TYPO3 finally 100% Composer compliant by installing ALL packages in the vendor folder! And on top our implementation is even better than the Symfony's one 😄 -
Simon Gilli commented on patch set 14 V -1 10/03/21, 17:14
Find two minor issues when installing everything to the vendor folder. -
Helmut Hummel uploaded patch set 15 10/03/21, 17:42
-
Helmut Hummel uploaded patch set 16 10/03/21, 17:50
-
core-ci voted on patch set 15 V +1 10/03/21, 17:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17520
-
Simon Gilli commented on patch set 16 V +1 CR +1 10/03/21, 18:02
Reply
One of the mentioned issues is related to the TYPO3 Console, the other one is fixed with PS 16. -
core-ci voted on patch set 16 V +1 10/03/21, 18:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17521
-
Andreas Kienast voted on patch set 16 CR +1 10/04/21, 14:00
-
Benni Mack commented on patch set 16 V +2 CR +2 10/04/21, 14:56
yay! -
Benni Mack merged patch set 17 10/04/21, 14:56
-
Markus Klein commented on patch set 17 10/07/21, 15:07
StorageRepository.php:369UnresolvedThis is wrong, it must be getPublicPath(). Otherwise the processingfolder above is generated in the wrong folder, which is not accessible for the webserver.