Review main Merged

71407[BUGFIX] Properly calculate web path for composer packages

Helmut Hummel CR +2 V +2 Normal +149 −71 updated 10/07/21, 15:07

Commit message

Composer packages are installed into vendor folder by
Composer and per definition this folder is not inside
the web root. Therefore URI calculation and publishing
must be different from packages/extensions that are installed
into the document root.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 2440

Show 815 earlier messages
  1. Helmut Hummel uploaded patch set 1 10/01/21, 15:09

  2. core-ci voted on patch set 1 V -1 10/01/21, 15:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17445

  3. Helmut Hummel rebased onto patch set 2 10/01/21, 22:47

  4. core-ci voted on patch set 2 V -1 10/01/21, 22:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17465

  5. Helmut Hummel uploaded patch set 3 10/01/21, 23:10

  6. core-ci voted on patch set 3 V -1 10/01/21, 23:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17471

  7. Helmut Hummel uploaded patch set 4 10/02/21, 17:09

  8. core-ci voted on patch set 4 V -1 10/02/21, 17:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17494

  9. Helmut Hummel uploaded patch set 5 10/02/21, 18:47

  10. core-ci voted on patch set 5 V -1 10/02/21, 18:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17496

  11. Helmut Hummel uploaded patch set 6 10/03/21, 07:31

  12. core-ci voted on patch set 6 V -1 10/03/21, 07:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17500

  13. Helmut Hummel uploaded patch set 7 10/03/21, 08:12

  14. core-ci voted on patch set 7 V -1 10/03/21, 08:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17501

  15. Helmut Hummel uploaded patch set 8 10/03/21, 08:19

  1. Helmut Hummel uploaded patch set 9 10/03/21, 08:21

  2. core-ci voted on patch set 8 V -1 10/03/21, 08:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17503

  3. core-ci voted on patch set 9 V +1 10/03/21, 08:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17504

  4. Helmut Hummel uploaded patch set 10 10/03/21, 09:14

  5. Helmut Hummel uploaded patch set 11 10/03/21, 09:33

  6. core-ci voted on patch set 10 V +1 10/03/21, 09:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17505

  7. core-ci voted on patch set 11 V +1 10/03/21, 09:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17506

  8. Helmut Hummel uploaded patch set 12 10/03/21, 12:41

  9. core-ci voted on patch set 12 V -1 10/03/21, 12:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17507

  10. Helmut Hummel uploaded patch set 13 10/03/21, 13:33

  11. core-ci voted on patch set 13 V +1 10/03/21, 13:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17508

  12. Helmut Hummel uploaded patch set 14 10/03/21, 14:03

  13. core-ci voted on patch set 14 V +1 10/03/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17510

  14. Simon Gilli commented on patch set 14 V -1 10/03/21, 14:30

    On it. Still need to test some parts but most should work fine in the meantime.
  15. Simon Gilli commented on patch set 14 V +1 CR +1 10/03/21, 16:10

    After two days of testing finally everything works and I'm not able to find more bugs. I did some really extensive tests using the introduction and bootstrap package. The first testing scenario was with the extensions installed in typo3/sysext and typo3conf/ext (Composer legacy install). For the second tests I've used a modified cms-composer-installers package where all packages were installed in the vendor folder (Composer compliant install). Thanks Helmut for this great patch which makes TYPO3 finally 100% Composer compliant by installing ALL packages in the vendor folder! And on top our implementation is even better than the Symfony's one 😄
  16. Simon Gilli commented on patch set 14 V -1 10/03/21, 17:14

    Find two minor issues when installing everything to the vendor folder.
  17. Helmut Hummel uploaded patch set 15 10/03/21, 17:42

  18. Helmut Hummel uploaded patch set 16 10/03/21, 17:50

  19. core-ci voted on patch set 15 V +1 10/03/21, 17:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17520

  20. Simon Gilli commented on patch set 16 V +1 CR +1 10/03/21, 18:02

    Reply

    One of the mentioned issues is related to the TYPO3 Console, the other one is fixed with PS 16.
  21. core-ci voted on patch set 16 V +1 10/03/21, 18:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17521

  22. Andreas Kienast voted on patch set 16 CR +1 10/04/21, 14:00

  23. Benni Mack commented on patch set 16 V +2 CR +2 10/04/21, 14:56

    yay!
  24. Benni Mack merged patch set 17 10/04/21, 14:56

  25. Markus Klein commented on patch set 17 10/07/21, 15:07

    StorageRepository.php:369 Unresolved

    This is wrong, it must be getPublicPath(). Otherwise the processingfolder above is generated in the wrong folder, which is not accessible for the webserver.