Review main Merged

71410[BUGFIX] Fix notification for autogenerated slug redirects

Benjamin Franzke CR +2 V +2 Normal +50 −8 updated 10/01/21, 20:40

Commit message

Since #94114 EditDocumentController POST requests are
redirected to GET. (Inline) javascript that is added to
PageRenderer during processing of such POST request never
reaches to the browser and therefore caused notifications
to be omitted for automatically created redirects (#89115).

Use a update signal to delay notification delivery to the
GET request.

Also fix a misleading language label to clarifiy
that slugs of sub pages are being reverted, not the
slug that has been changed by the editor.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 911

  1. Benjamin Franzke uploaded patch set 1 10/01/21, 19:10

  2. Benjamin Franzke rebased onto patch set 2 10/01/21, 19:10

  3. Benjamin Franzke commented on patch set 2 10/01/21, 19:18

    I know that it is unfortunate to use inline javascript to fix this. But please see the following arguments: a) it has been used before as well b) we can't introduce a new API (Feature) to provide delayed messaged without inline js (web components) I think that's something for v12 to generally replace the inline-js updateSignals with web components.
  4. core-ci voted on patch set 2 V +1 10/01/21, 19:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17460

  5. Benjamin Franzke voted on patch set 2 CR -1 10/01/21, 19:23

  6. Benjamin Franzke uploaded patch set 3 10/01/21, 19:38

  7. core-ci voted on patch set 3 V +1 10/01/21, 19:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17461

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 10/01/21, 20:14

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 10/01/21, 20:22

  10. Benjamin Franzke voted on patch set 3 V +2 CR +2 10/01/21, 20:40

  11. Benjamin Franzke merged patch set 4 10/01/21, 20:40