71410[BUGFIX] Fix notification for autogenerated slug redirects
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 4
Review log 911
-
Benjamin Franzke uploaded patch set 1 10/01/21, 19:10
-
Benjamin Franzke rebased onto patch set 2 10/01/21, 19:10
-
Benjamin Franzke commented on patch set 2 10/01/21, 19:18
I know that it is unfortunate to use inline javascript to fix this. But please see the following arguments: a) it has been used before as well b) we can't introduce a new API (Feature) to provide delayed messaged without inline js (web components) I think that's something for v12 to generally replace the inline-js updateSignals with web components. -
core-ci voted on patch set 2 V +1 10/01/21, 19:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17460
-
Benjamin Franzke voted on patch set 2 CR -1 10/01/21, 19:23
-
Benjamin Franzke uploaded patch set 3 10/01/21, 19:38
-
core-ci voted on patch set 3 V +1 10/01/21, 19:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17461
-
Oli Bartsch voted on patch set 3 V +1 CR +1 10/01/21, 20:14
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/01/21, 20:22
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 10/01/21, 20:40
-
Benjamin Franzke merged patch set 4 10/01/21, 20:40