Review main Abandoned

71414[BUGFIX] Provide arguments in correct order to DataHandler log method

TYPO3com CR 0 V 0 Easy +1 −1 updated 11/09/21, 20:57

Commit message

The first array entry for "$data" is the replacement for "%s" in
vsprintf. The order has been swapped, so the wrong e-mail is the
replacement instead of the localized error message.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1015

  1. TYPO3com uploaded patch set 1 10/02/21, 08:44

  2. core-ci voted on patch set 1 V +1 10/02/21, 09:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17478

  3. Nikita Hovratov uploaded patch set 2 10/05/21, 10:47

  4. core-ci voted on patch set 2 V +1 10/05/21, 11:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17607

  5. Davide Alghi commented on patch set 2 10/06/21, 08:22

    The change partially fixes the bug: it only works with the message ('"%s" is not a valid e-mail address.') assigned to $details parameter, in "function log()". If you test with a language other than English, the problem is immediately visible. Furthermore the problem, which I have pointed out, is also present here https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1443
  6. Nikita Hovratov commented on patch set 2 10/06/21, 08:26

    Reply Unresolved

    In the second one there is no "%s". What is exactly the problem there?
  7. Davide Alghi commented on patch set 2 10/06/21, 08:38

    the prob is the same: the lang
  8. Nikita Hovratov commented on patch set 2 10/06/21, 08:48

    Reply Unresolved

    As this is logged, it should always be in english. I agree with you, that it's not optimal to show english messages in the backend, too. But I would say, this is another issue. Let's fix the most obvious one with this first.
  9. Davide Alghi commented on patch set 2 10/06/21, 09:27

    ok
  10. Nikita Hovratov uploaded patch set 3 11/09/21, 20:19

  11. Nikita Hovratov updated the commit message in patch set 4 11/09/21, 20:25

  12. core-ci voted on patch set 3 V +1 11/09/21, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19087

  13. core-ci voted on patch set 4 V +1 11/09/21, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19088

  14. Christian Kuhn commented on patch set 4 11/09/21, 20:57

    Abandoning master version, since that has been recently fixed with #95459. Pushed a dedicated v10 version.
  15. Christian Kuhn abandoned the change 11/09/21, 20:57