Review main Merged

71416[TASK] Deprecate AbstractControl::setOnClick for backend user interface

Oliver Hader CR +2 V +2 Normal +194 −3 updated 10/02/21, 14:48

Commit message

In favor of allowing content-security-policy headers (some day), inline
JavaScript invocation via PHP in `AbstractControl::setOnClick` has been
deprecated. Existing instructions can be migrated using existing
JavaScript helpers `GlobalEventHandler` or `ActionDispatcher`.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Oliver Hader uploaded patch set 1 10/02/21, 10:51

  2. core-ci voted on patch set 1 V +1 10/02/21, 11:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17483

  3. Oliver Hader uploaded patch set 2 10/02/21, 13:17

  4. Oliver Hader updated the commit message in patch set 3 10/02/21, 13:17

  5. Oliver Hader wrote 10/02/21, 13:22

    Topic set to inline-javascript
  6. Oliver Hader uploaded patch set 4 10/02/21, 13:28

  7. core-ci voted on patch set 2 V +1 10/02/21, 13:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17487

  8. core-ci voted on patch set 3 V +1 10/02/21, 13:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17488

  9. Stefan Bürk voted on patch set 4 CR +1 10/02/21, 13:45

  10. core-ci voted on patch set 4 V +1 10/02/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17489

  11. Stefan Bürk voted on patch set 4 V +1 10/02/21, 14:24

  12. Helmut Hummel voted on patch set 4 V +2 CR +2 10/02/21, 14:48

  13. Helmut Hummel merged patch set 5 10/02/21, 14:48