Review main Merged

71425[BUGFIX] Prevent possible TypeError in LanguageColumn

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/04/21, 13:26

Commit message

PreviewUriBuilder->serializeDispatcherAttributes() returns
null|string. Since the return type declaration of getPreviewUrlAttributes()
is string, we need to cast the value before returning it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/04/21, 11:15

  2. core-ci voted on patch set 1 V +1 10/04/21, 11:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17550

  3. Oliver Klee voted on patch set 1 CR +1 10/04/21, 12:47

  4. Benni Mack commented on patch set 1 V +1 CR +1 10/04/21, 13:17

    that was such an annoying bug. thanks
  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/04/21, 13:19

  6. Benni Mack voted on patch set 1 V +2 CR +2 10/04/21, 13:25

  7. Benni Mack merged patch set 2 10/04/21, 13:26