71428[TASK] Improve default error page
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Mathias Bolt Lesniak +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/Sass/errorpage.scssdeleted+0 −147
- Build/Gruntfile.js+0 −5
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+2 −1
- typo3/sysext/core/Classes/Controller/ErrorPageController.php8+5 −21
- typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php+2 −1
- typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html3+91 −44
- typo3/sysext/core/Resources/Public/Css/errorpage.cssdeleted+0 −13
- typo3/sysext/frontend/Classes/Controller/ErrorController.php+5 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php4+2 −2
Review log 3746
Show 1521 earlier messages
-
Benjamin Kott uploaded patch set 1 10/04/21, 13:31
-
Benjamin Kott uploaded patch set 2 10/04/21, 13:32
-
Benjamin Kott uploaded patch set 3 10/04/21, 13:34
-
core-ci voted on patch set 1 V -1 10/04/21, 13:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17559
-
core-ci voted on patch set 2 V -1 10/04/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17560
-
core-ci voted on patch set 3 V -1 10/04/21, 13:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17562
-
Nikita Hovratov commented on patch set 3 10/04/21, 13:42
Missing "#" -
Nikita Hovratov commented on patch set 3 10/04/21, 13:44
Looks nice! -
Simon Schaufelberger commented on patch set 3 V +1 CR +1 10/04/21, 13:51
I can confirm that it is better than before and looks much better! -
Benni Mack uploaded patch set 4 10/04/21, 14:23
-
Nikita Hovratov commented on patch set 4 10/04/21, 14:26
Reply
Done -
core-ci voted on patch set 4 V -1 10/04/21, 14:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17564
-
Benni Mack uploaded patch set 5 10/04/21, 14:44
-
Helmut Hummel commented on patch set 5 CR -2 10/04/21, 14:49
Please don't merge this like this. Will comment in a sec. -
Benjamin Franzke commented on patch set 5 10/04/21, 14:52
ErrorPageController.php:81errorpage.css could/should be placed Ressources/Private/Css then -
Benni Mack commented on patch set 5 10/04/21, 14:52
Reply
yeah, we need to use the Package API now. Also, there is still a todo in there. -
core-ci voted on patch set 5 V +1 10/04/21, 15:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17566
-
Helmut Hummel commented on patch set 5 CR -1 10/04/21, 15:55
ErrorPageController.php:72I'm not 100% convinced about this API change, but I guess it is fine.ErrorPageController.php:81ReplyYeah, was not sure at first what was going on here, but if this CSS is moved to Resources/Private/Css, and the SVG is inlined in HTML then it is totally fine. -
Benni Mack uploaded patch set 6 10/04/21, 16:04
-
Benni Mack commented on patch set 6 10/04/21, 16:15
ErrorPageController.php:72Replythe actual ErrorPageController isn't a huge deal actually, I think you mean the "PageErrorHandlerInterface" (yes, naming was hard :() -
core-ci voted on patch set 6 V -1 10/04/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17573
-
Benni Mack uploaded patch set 7 10/04/21, 16:26
-
core-ci voted on patch set 7 V +1 10/04/21, 16:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17575
-
Benni Mack commented on patch set 7 V +1 CR +1 10/04/21, 16:47
issues resolved, I'd say. -
Mathias Bolt Lesniak voted on patch set 7 CR +1 10/04/21, 16:56
-
Nikita Hovratov commented on patch set 7 10/04/21, 16:59
UriPrefixRenderingTest.php:35Should backend.css be 2 times there? -
Helmut Hummel voted on patch set 7 V +2 CR +2 10/04/21, 17:01
-
Helmut Hummel commented on patch set 7 V 0 CR 0 10/04/21, 17:03
Reply
AckErrorPageController.php:72ReplyAckUriPrefixRenderingTest.php:35Replyah darn, no, should be removed -
Helmut Hummel commented on patch set 7 10/04/21, 17:03
ErrorPageController.php:81ReplyDone -
Oli Bartsch commented on patch set 7 10/04/21, 17:12
UriPrefixRenderingTest.php:35ReplyIsn't this just a testcase for a relative path? -
Nikita Hovratov commented on patch set 7 V +1 CR +1 10/04/21, 17:24
UriPrefixRenderingTest.php:35ReplyAh, yes. Seems it does no harm having the same file two times included. -
Georg Ringer commented on patch set 7 10/04/21, 17:59
Error.html:91can we keep the rel="noreferrer" and maybe also target _blank? -
Benni Mack commented on patch set 7 10/04/21, 18:29
Error.html:91Replygood idea. will update -
Benni Mack commented on patch set 8 10/04/21, 18:30
Published edit on patch set 7. -
Mathias Bolt Lesniak voted on patch set 8 CR +1 10/04/21, 18:32
-
core-ci voted on patch set 8 V +1 10/04/21, 18:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17584
-
Benni Mack voted on patch set 8 V +1 CR +1 10/04/21, 20:15
-
Oli Bartsch commented on patch set 8 10/04/21, 20:26
ErrorPageController.php:68This has no effect anymore, right? -
Andreas Kienast voted on patch set 8 V +2 CR +2 10/04/21, 20:27
-
Andreas Kienast commented on patch set 8 CR -1 10/04/21, 20:28
on it -
Andreas Kienast uploaded patch set 9 10/04/21, 20:37
-
Oli Bartsch commented on patch set 9 V +1 CR +1 10/04/21, 20:39
ErrorPageController.php:68ReplyDoneError.html:91ReplyDone -
core-ci voted on patch set 9 V +1 10/04/21, 20:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17590
-
Mathias Bolt Lesniak voted on patch set 9 CR +1 10/04/21, 21:02
-
Andreas Kienast voted on patch set 9 V +2 CR +2 10/04/21, 21:02
-
Andreas Kienast merged patch set 10 10/04/21, 21:02