Review main Merged

71428[TASK] Improve default error page

Benjamin Kott CR +2 V +2 Hard +107 −235 updated 10/04/21, 21:02

Commit message

This change removes the information about "no liability"
and uses modern CSS to improve the output and rendering
of the default error page.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Mathias Bolt Lesniak +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 3746

Show 1521 earlier messages
  1. Benjamin Kott uploaded patch set 1 10/04/21, 13:31

  2. Benjamin Kott uploaded patch set 2 10/04/21, 13:32

  3. Benjamin Kott uploaded patch set 3 10/04/21, 13:34

  4. core-ci voted on patch set 1 V -1 10/04/21, 13:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17559

  5. core-ci voted on patch set 2 V -1 10/04/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17560

  6. core-ci voted on patch set 3 V -1 10/04/21, 13:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17562

  7. Nikita Hovratov commented on patch set 3 10/04/21, 13:42

    Missing "#"
  8. Nikita Hovratov commented on patch set 3 10/04/21, 13:44

    Looks nice!
  9. Simon Schaufelberger commented on patch set 3 V +1 CR +1 10/04/21, 13:51

    I can confirm that it is better than before and looks much better!
  10. Benni Mack uploaded patch set 4 10/04/21, 14:23

  11. Nikita Hovratov commented on patch set 4 10/04/21, 14:26

    Reply

    Done
  12. core-ci voted on patch set 4 V -1 10/04/21, 14:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17564

  13. Benni Mack uploaded patch set 5 10/04/21, 14:44

  14. Helmut Hummel commented on patch set 5 CR -2 10/04/21, 14:49

    Please don't merge this like this. Will comment in a sec.
  15. Benjamin Franzke commented on patch set 5 10/04/21, 14:52

    ErrorPageController.php:81

    errorpage.css could/should be placed Ressources/Private/Css then
  16. Benni Mack commented on patch set 5 10/04/21, 14:52

    Reply

    yeah, we need to use the Package API now. Also, there is still a todo in there.
  17. core-ci voted on patch set 5 V +1 10/04/21, 15:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17566

  18. Helmut Hummel commented on patch set 5 CR -1 10/04/21, 15:55

    ErrorPageController.php:72

    I'm not 100% convinced about this API change, but I guess it is fine.

    ErrorPageController.php:81 Reply

    Yeah, was not sure at first what was going on here, but if this CSS is moved to Resources/Private/Css, and the SVG is inlined in HTML then it is totally fine.
  19. Benni Mack uploaded patch set 6 10/04/21, 16:04

  20. Benni Mack commented on patch set 6 10/04/21, 16:15

    ErrorPageController.php:72 Reply

    the actual ErrorPageController isn't a huge deal actually, I think you mean the "PageErrorHandlerInterface" (yes, naming was hard :()
  21. core-ci voted on patch set 6 V -1 10/04/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17573

  1. Benni Mack uploaded patch set 7 10/04/21, 16:26

  2. core-ci voted on patch set 7 V +1 10/04/21, 16:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17575

  3. Benni Mack commented on patch set 7 V +1 CR +1 10/04/21, 16:47

    issues resolved, I'd say.
  4. Mathias Bolt Lesniak voted on patch set 7 CR +1 10/04/21, 16:56

  5. Nikita Hovratov commented on patch set 7 10/04/21, 16:59

    UriPrefixRenderingTest.php:35

    Should backend.css be 2 times there?
  6. Helmut Hummel voted on patch set 7 V +2 CR +2 10/04/21, 17:01

  7. Helmut Hummel commented on patch set 7 V 0 CR 0 10/04/21, 17:03

    Reply

    Ack

    ErrorPageController.php:72 Reply

    Ack

    UriPrefixRenderingTest.php:35 Reply

    ah darn, no, should be removed
  8. Helmut Hummel commented on patch set 7 10/04/21, 17:03

    ErrorPageController.php:81 Reply

    Done
  9. Oli Bartsch commented on patch set 7 10/04/21, 17:12

    UriPrefixRenderingTest.php:35 Reply

    Isn't this just a testcase for a relative path?
  10. Nikita Hovratov commented on patch set 7 V +1 CR +1 10/04/21, 17:24

    UriPrefixRenderingTest.php:35 Reply

    Ah, yes. Seems it does no harm having the same file two times included.
  11. Georg Ringer commented on patch set 7 10/04/21, 17:59

    Error.html:91

    can we keep the rel="noreferrer" and maybe also target _blank?
  12. Benni Mack commented on patch set 7 10/04/21, 18:29

    Error.html:91 Reply

    good idea. will update
  13. Benni Mack commented on patch set 8 10/04/21, 18:30

    Published edit on patch set 7.
  14. Mathias Bolt Lesniak voted on patch set 8 CR +1 10/04/21, 18:32

  15. core-ci voted on patch set 8 V +1 10/04/21, 18:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17584

  16. Benni Mack voted on patch set 8 V +1 CR +1 10/04/21, 20:15

  17. Oli Bartsch commented on patch set 8 10/04/21, 20:26

    ErrorPageController.php:68

    This has no effect anymore, right?
  18. Andreas Kienast voted on patch set 8 V +2 CR +2 10/04/21, 20:27

  19. Andreas Kienast commented on patch set 8 CR -1 10/04/21, 20:28

    on it
  20. Andreas Kienast uploaded patch set 9 10/04/21, 20:37

  21. Oli Bartsch commented on patch set 9 V +1 CR +1 10/04/21, 20:39

    ErrorPageController.php:68 Reply

    Done

    Error.html:91 Reply

    Done
  22. core-ci voted on patch set 9 V +1 10/04/21, 20:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17590

  23. Mathias Bolt Lesniak voted on patch set 9 CR +1 10/04/21, 21:02

  24. Andreas Kienast voted on patch set 9 V +2 CR +2 10/04/21, 21:02

  25. Andreas Kienast merged patch set 10 10/04/21, 21:02