Review main Merged

71429[TASK] Use str_contains instead of strpos where possible

Nikita Hovratov CR +2 V +2 Hard +249 −249 updated 10/12/21, 09:30

Commit message

The (ugly) statement strpos($haystack, 'needle') !== false can be safely
replaced with str_contains($haystack, 'needle'). This is possible, as
a symfony polyfill for php 8.0 functions is in place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 129

Show 109 more files

Review log 1620

  1. Nikita Hovratov uploaded patch set 1 10/04/21, 15:21

  2. core-ci voted on patch set 1 V -1 10/04/21, 15:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17570

  3. Nikita Hovratov uploaded patch set 2 10/04/21, 15:52

  4. core-ci voted on patch set 2 V +1 10/04/21, 16:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17572

  5. Georg Ringer voted on patch set 2 V +1 CR +1 10/05/21, 18:25

  6. Simon Schaufelberger commented on patch set 2 CR +1 10/05/21, 20:07

    Did you do that manually or with rector?
  7. Nikita Hovratov commented on patch set 2 10/05/21, 20:20

    Reply

    With a phpstorm plugin.
  8. Simon Schaufelberger voted on patch set 2 V +1 10/08/21, 11:40

  9. crell voted on patch set 2 CR +1 10/08/21, 12:37

  10. Nikita Hovratov uploaded patch set 3 10/11/21, 10:57

  11. Nikita Hovratov commented on patch set 3 10/11/21, 10:58

    Only rebased, please vote again.
  12. Simon Schaufelberger voted on patch set 3 V +1 CR +1 10/11/21, 11:02

  13. core-ci voted on patch set 3 V +1 10/11/21, 11:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17911

  14. Nikita Hovratov uploaded patch set 4 10/11/21, 13:12

  15. Nikita Hovratov commented on patch set 4 10/11/21, 13:12

    Another rebase :)
  16. core-ci voted on patch set 4 V +1 10/11/21, 13:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17916

  17. Simon Schaufelberger voted on patch set 4 V +1 CR +1 10/11/21, 13:55

  18. Wouter Wolters voted on patch set 4 CR +1 10/11/21, 17:27

  19. Benni Mack voted on patch set 4 V +2 CR +2 10/12/21, 09:30

  20. Benni Mack merged patch set 5 10/12/21, 09:30