71429[TASK] Use str_contains instead of strpos where possible
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 129
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Configuration/BackendUserConfiguration.php+2 −2
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRecordTypeValue.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+1 −1
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+1 −1
- typo3/sysext/backend/Classes/Http/Application.php+1 −1
- typo3/sysext/backend/Classes/Middleware/LockedBackendGuard.php+1 −1
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+5 −5
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/FileStorageTreeProvider.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayoutCollection.php+2 −2
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderCollection.php+2 −2
Show 109 more files
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+1 −1
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/Totp.php+1 −1
- typo3/sysext/core/Classes/Authentication/IpLocker.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php+1 −1
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvVariableProcessor.php+1 −1
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/ValueFromReferenceArrayProcessor.php+1 −1
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+1 −1
- typo3/sysext/core/Classes/Core/ApplicationContext.php+1 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaIndexDefinitionListener.php+4 −4
- typo3/sysext/core/Classes/Database/Schema/Parser/Lexer.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+4 −4
- typo3/sysext/core/Classes/Database/QueryView.php+4 −4
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+14 −14
- typo3/sysext/core/Classes/Http/Dispatcher.php+2 −2
- typo3/sysext/core/Classes/Http/Stream.php+1 −1
- typo3/sysext/core/Classes/Http/Uri.php+3 −3
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+4 −4
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+8 −8
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/Log/Processor/IntrospectionProcessor.php+1 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+3 −3
- typo3/sysext/core/Classes/Preparations/TcaPreparation.php+1 −1
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+1 −1
- typo3/sysext/core/Classes/Resource/Filter/FileNameFilter.php+1 −1
- typo3/sysext/core/Classes/Resource/Security/FileMetadataPermissionsAspect.php+2 −2
- typo3/sysext/core/Classes/Resource/RelativeCssPathFixer.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+2 −2
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php+2 −2
- typo3/sysext/core/Classes/Routing/PageRouter.php+1 −1
- typo3/sysext/core/Classes/Service/FlexFormService.php+1 −1
- typo3/sysext/core/Classes/Site/Entity/Site.php+2 −2
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+10 −10
- typo3/sysext/core/Classes/TypoScript/TypoScriptService.php+1 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+8 −8
- typo3/sysext/core/Classes/Utility/PathUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/ResourceUtility.php+3 −3
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/AbstractIntroductionPackage.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+1 −1
- typo3/sysext/extbase/Classes/Error/Result.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+3 −3
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+2 −2
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+1 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorClassNameResolver.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ErrorController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −3
- typo3/sysext/frontend/Classes/Page/CacheHashConfiguration.php+1 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+1 −1
- typo3/sysext/frontend/Classes/Service/TypoLinkCodecService.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+4 −4
- typo3/sysext/impexp/Classes/Import.php+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+2 −2
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −1
- typo3/sysext/install/Classes/Command/LanguagePackCommand.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/CodeStatistics.php+2 −2
- typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/LinkNode.php+1 −1
- typo3/sysext/install/Classes/Service/EnableFileService.php+1 −1
- typo3/sysext/install/Classes/Service/WebServerConfigurationFileService.php+2 −2
- typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/FileDeclaration.php+2 −2
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+6 −6
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+8 −8
- typo3/sysext/recordlist/Classes/Browser/FolderBrowser.php+1 −1
- typo3/sysext/redirects/Classes/Evaluation/SourceHost.php+2 −2
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+1 −1
- typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php+5 −5
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+1 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+2 −2
Review log 1620
-
Nikita Hovratov uploaded patch set 1 10/04/21, 15:21
-
core-ci voted on patch set 1 V -1 10/04/21, 15:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17570
-
Nikita Hovratov uploaded patch set 2 10/04/21, 15:52
-
core-ci voted on patch set 2 V +1 10/04/21, 16:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17572
-
Georg Ringer voted on patch set 2 V +1 CR +1 10/05/21, 18:25
-
Simon Schaufelberger commented on patch set 2 CR +1 10/05/21, 20:07
Did you do that manually or with rector? -
Nikita Hovratov commented on patch set 2 10/05/21, 20:20
Reply
With a phpstorm plugin. -
Simon Schaufelberger voted on patch set 2 V +1 10/08/21, 11:40
-
crell voted on patch set 2 CR +1 10/08/21, 12:37
-
Nikita Hovratov uploaded patch set 3 10/11/21, 10:57
-
Nikita Hovratov commented on patch set 3 10/11/21, 10:58
Only rebased, please vote again. -
Simon Schaufelberger voted on patch set 3 V +1 CR +1 10/11/21, 11:02
-
core-ci voted on patch set 3 V +1 10/11/21, 11:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17911
-
Nikita Hovratov uploaded patch set 4 10/11/21, 13:12
-
Nikita Hovratov commented on patch set 4 10/11/21, 13:12
Another rebase :) -
core-ci voted on patch set 4 V +1 10/11/21, 13:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17916
-
Simon Schaufelberger voted on patch set 4 V +1 CR +1 10/11/21, 13:55
-
Wouter Wolters voted on patch set 4 CR +1 10/11/21, 17:27
-
Benni Mack voted on patch set 4 V +2 CR +2 10/12/21, 09:30
-
Benni Mack merged patch set 5 10/12/21, 09:30