Review main Merged

71430[BUGFIX] Show broken links for all languages

Sybille Peters CR +2 V +2 Easy +5 −2 updated 10/11/21, 14:53

Commit message

If no allowed languages are defined for a BE user / group
([allowed_languages] is not set), only broken links in records
of the default language were shown for editors.

This was incorrect and this patch fixes the problem.

Broken links in translated records will now always be shown
for editors (if they have write access to the records).

Background information:

Linkvalidator checks if the current editor has write access to
the elements / fields in which the broken links are contained.
This ensures that only broken links will be displayed, if the
editor can fix them.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Sybille Peters uploaded patch set 1 10/04/21, 16:25

  2. Sybille Peters updated the commit message in patch set 2 10/04/21, 16:36

  3. core-ci voted on patch set 1 V +1 10/04/21, 16:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17574

  4. core-ci voted on patch set 2 V +1 10/04/21, 16:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17576

  5. Wouter Wolters voted on patch set 2 CR +1 10/04/21, 17:29

  6. Oli Bartsch uploaded patch set 3 10/11/21, 11:48

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 10/11/21, 11:48

  8. core-ci voted on patch set 3 V +1 10/11/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17913

  9. Jochen Roth voted on patch set 3 V +1 CR +1 10/11/21, 12:50

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/11/21, 14:53

  11. Benni Mack merged patch set 4 10/11/21, 14:53