Review main Merged

71432[BUGFIX] Ignore dependencies to replaced composer packages

Helmut Hummel CR +2 V +2 Easy +8 −1 updated 10/04/21, 23:53

Commit message

Logic was introduced to ignore dependencies to composer
packages that TYPO3 extensions depend on during
calculation of extension order.

However replaces of packages were not considered, which
can lead to an exception, when a TYPO3 extension depends
on a Composer package, that is replaced by another package
within a particular Composer installation.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1419

  1. Helmut Hummel uploaded patch set 1 10/04/21, 16:52

  2. Simon Gilli voted on patch set 1 CR +1 10/04/21, 17:08

  3. core-ci voted on patch set 1 V -1 10/04/21, 17:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17579

  4. Simon Gilli commented on patch set 1 V +1 10/04/21, 17:13

    Great, thanks! Replacing packages works now properly.
  5. Wouter Wolters commented on patch set 1 10/04/21, 17:46

    PackageArtifactBuilder.php:154

    phpstan reports that is doesn't know this class. PHPDoc tag @var for variable $composerPackage contains unknown class Composer\Package\PackageInterface.
  6. Simon Gilli uploaded patch set 2 10/04/21, 17:51

  7. Simon Gilli commented on patch set 2 10/04/21, 17:54

    PackageArtifactBuilder.php:154 Reply

    Yes, that's expected because it's only available at composer runtime. PS2 should fix this error.
  8. Simon Gilli voted on patch set 2 V +1 CR +1 10/04/21, 17:54

  9. core-ci voted on patch set 2 V -1 10/04/21, 18:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17582

  10. Simon Gilli uploaded patch set 3 10/04/21, 18:17

  11. Simon Gilli commented on patch set 3 V +1 CR +1 10/04/21, 18:20

    Great, another try, the root phpstan.neon does not use tabs but spaces. The files in Build properly using tabs like defined by the .editorconfig.
  12. core-ci voted on patch set 3 V -1 10/04/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17583

  13. Simon Gilli uploaded patch set 4 10/04/21, 19:13

  14. core-ci voted on patch set 4 V -1 10/04/21, 19:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17586

  15. Helmut Hummel uploaded patch set 5 10/04/21, 20:49

  16. Simon Gilli voted on patch set 5 V +1 CR +1 10/04/21, 20:50

  17. core-ci voted on patch set 5 V +1 10/04/21, 21:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17591

  18. Helmut Hummel commented on patch set 5 V +2 CR +2 10/04/21, 23:53

    I know votes are missing here, but I'm confident this change is fine and it would be a pity to not have it in the final release
  19. Helmut Hummel merged patch set 6 10/04/21, 23:53