71432[BUGFIX] Ignore dependencies to replaced composer packages
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1419
-
Helmut Hummel uploaded patch set 1 10/04/21, 16:52
-
Simon Gilli voted on patch set 1 CR +1 10/04/21, 17:08
-
core-ci voted on patch set 1 V -1 10/04/21, 17:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17579
-
Simon Gilli commented on patch set 1 V +1 10/04/21, 17:13
Great, thanks! Replacing packages works now properly. -
Wouter Wolters commented on patch set 1 10/04/21, 17:46
PackageArtifactBuilder.php:154phpstan reports that is doesn't know this class. PHPDoc tag @var for variable $composerPackage contains unknown class Composer\Package\PackageInterface. -
Simon Gilli uploaded patch set 2 10/04/21, 17:51
-
Simon Gilli commented on patch set 2 10/04/21, 17:54
PackageArtifactBuilder.php:154ReplyYes, that's expected because it's only available at composer runtime. PS2 should fix this error. -
Simon Gilli voted on patch set 2 V +1 CR +1 10/04/21, 17:54
-
core-ci voted on patch set 2 V -1 10/04/21, 18:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17582
-
Simon Gilli uploaded patch set 3 10/04/21, 18:17
-
Simon Gilli commented on patch set 3 V +1 CR +1 10/04/21, 18:20
Great, another try, the root phpstan.neon does not use tabs but spaces. The files in Build properly using tabs like defined by the .editorconfig. -
core-ci voted on patch set 3 V -1 10/04/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17583
-
Simon Gilli uploaded patch set 4 10/04/21, 19:13
-
core-ci voted on patch set 4 V -1 10/04/21, 19:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17586
-
Helmut Hummel uploaded patch set 5 10/04/21, 20:49
-
Simon Gilli voted on patch set 5 V +1 CR +1 10/04/21, 20:50
-
core-ci voted on patch set 5 V +1 10/04/21, 21:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17591
-
Helmut Hummel commented on patch set 5 V +2 CR +2 10/04/21, 23:53
I know votes are missing here, but I'm confident this change is fine and it would be a pity to not have it in the final release -
Helmut Hummel merged patch set 6 10/04/21, 23:53