Review main Merged

71434[TASK] Resolve TODO in MFA activate action

Benjamin Franzke CR +2 V +2 Easy +2 −6 updated 10/05/21, 07:51

Commit message

With #95287 there was a bit of uncertainty whether a successful
return value of MfaProviderInterface::activate() indicates
"no error happened" or "provider became active".

The todo is now removed to align with the update() method
which follows "no error happened" pattern.

As update() allows providers to go inactive
with successful return value, activate() is therefore now
officially aligned to behave the same by removing the TODO.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1215

  1. Benjamin Franzke uploaded patch set 1 10/05/21, 06:56

  2. Benni Mack commented on patch set 2 10/05/21, 07:02

    Published edit on patch set 1.
  3. Benjamin Franzke updated the commit message in patch set 3 10/05/21, 07:05

  4. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/05/21, 07:09

  5. Richard Haeser updated the commit message in patch set 4 10/05/21, 07:15

  6. Richard Haeser voted on patch set 4 V +1 CR +1 10/05/21, 07:16

  7. core-ci voted on patch set 3 V +1 10/05/21, 07:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17599

  8. Oli Bartsch commented on patch set 4 CR -1 10/05/21, 07:22

    On it
  9. core-ci voted on patch set 4 V +1 10/05/21, 07:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17600

  10. Oli Bartsch uploaded patch set 5 10/05/21, 07:30

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 10/05/21, 07:32

  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 10/05/21, 07:37

  13. core-ci voted on patch set 5 V +1 10/05/21, 07:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17602

  14. Benjamin Franzke voted on patch set 5 V +2 CR +2 10/05/21, 07:50

  15. Benjamin Franzke merged patch set 6 10/05/21, 07:51