Review main Merged

71436[DOCS] Add more details to the manual of EXT:impexp

Alexander Nitsche CR +2 V +2 Expert +620 −473 updated 10/13/21, 12:57

Commit message

Explanation of almost all configuration parameters.

Automatic creation of almost all screenshots. The file
`Documentation/screenshots.json` can be executed by the screenshots
project at https://github.com/TYPO3-Documentation/t3docs-screenshots.

Fixed the import preview error "ERROR: One of the inputs was not an
array!" temporarily by marking the box "Do not show differences in
records" and thus hiding the comparison view. This error must be
handled in the EXT:impexp.

The chapter "Distributions" has been removed and the
corresponding chapter in "TYPO3 Explained" has been linked instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Tom Warwick +1
    • core-ci +1 CI

Issues 1

Files 51

Show 31 more files

Review log 2644

Show 1019 earlier messages
  1. Alexander Nitsche uploaded patch set 1 10/05/21, 10:58

  2. core-ci voted on patch set 1 V +1 10/05/21, 11:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17608

  3. Alexander Nitsche uploaded patch set 2 10/05/21, 16:51

  4. core-ci voted on patch set 2 V +1 10/05/21, 17:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17631

  5. Alexander Nitsche uploaded patch set 3 10/06/21, 09:18

  6. core-ci voted on patch set 3 V +1 10/06/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17654

  7. Alexander Nitsche uploaded patch set 4 10/06/21, 13:09

  8. core-ci voted on patch set 4 V +1 10/06/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17667

  9. Alexander Nitsche uploaded patch set 5 10/06/21, 13:57

  10. core-ci voted on patch set 5 V +1 10/06/21, 14:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17669

  11. Alexander Nitsche uploaded patch set 6 10/06/21, 14:50

  12. core-ci voted on patch set 6 V +1 10/06/21, 15:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17678

  13. Alexander Nitsche uploaded patch set 7 10/06/21, 16:17

  14. core-ci voted on patch set 7 V +1 10/06/21, 16:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17684

  15. Benni Mack updated the commit message in patch set 8 10/07/21, 09:30

  16. core-ci voted on patch set 8 V +1 10/07/21, 09:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17725

  17. Alexander Nitsche uploaded patch set 9 10/07/21, 10:34

  18. core-ci voted on patch set 9 V +1 10/07/21, 10:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17728

  19. Alexander Nitsche uploaded patch set 10 10/07/21, 13:46

  1. core-ci voted on patch set 10 V +1 10/07/21, 14:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17747

  2. Alexander Nitsche updated the commit message in patch set 11 10/07/21, 14:56

  3. core-ci voted on patch set 11 V +1 10/07/21, 15:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17755

  4. Alexander Nitsche uploaded patch set 12 10/08/21, 14:25

  5. Alexander Nitsche uploaded patch set 13 10/08/21, 14:35

  6. core-ci voted on patch set 12 V +1 10/08/21, 14:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17823

  7. Alexander Nitsche uploaded patch set 14 10/08/21, 14:43

  8. core-ci voted on patch set 13 V +1 10/08/21, 14:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17824

  9. core-ci voted on patch set 14 V +1 10/08/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17825

  10. Lina Wolf commented on patch set 14 10/09/21, 05:53

  11. Lina Wolf updated the commit message in patch set 15 10/09/21, 05:53

  12. core-ci voted on patch set 15 V +1 10/09/21, 06:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17857

  13. Lina Wolf commented on patch set 15 CR -1 10/09/21, 06:23

    I think it is not nice that we have a screenshot of TYPO3 3.8 but no recent one on the introduction page. Should we add a recent one? See comments otherwise

    Index.rst:22

    Regression, we already fixed this in the previous version. This configuration only hides the import export tool from the context menu but doesn't disable it! Therefore this doesn't really improve security
  14. Alexander Nitsche commented on patch set 15 10/11/21, 09:25

    I wonder if we should move all important pages "Export", "Import", "Presets" etc. from "Usage" one up into the first level of the menu. The menu would still be small and it gives faster insights.

    Reply

    Sure. Do you have one in mind?

    Index.rst:22 Reply

    This paragraph was not changed in this patch. Nevertheless i would keep it, but change it to "Export functionality can also be hidden" which is more correct. Hidden or disabled: both enhance the security in my eyes, even if disabling would be more secure.
  15. Alexander Nitsche uploaded patch set 16 10/12/21, 08:55

  16. Alexander Nitsche commented on patch set 16 10/12/21, 08:59

    Reply

    Keeping it as-is for now.

    Reply

    As agreed on, a screenshot of the current export module has been added - for comparison with the screenshot of the export module of TYPO3 v3.8.

    Index.rst:22 Reply

    Done
  17. core-ci voted on patch set 16 V +1 10/12/21, 09:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17951

  18. Alexander Nitsche uploaded patch set 17 10/12/21, 09:39

  19. core-ci voted on patch set 17 V +1 10/12/21, 09:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17955

  20. Alexander Nitsche updated the commit message in patch set 18 10/12/21, 12:44

  21. Lina Wolf commented on patch set 18 V +1 CR +1 10/12/21, 12:53

    Looks fine to me, Renders without warnings
  22. core-ci voted on patch set 18 V +1 10/12/21, 13:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17969

  23. Tom Warwick voted on patch set 18 V +1 10/13/21, 11:39

  24. Christian Kuhn voted on patch set 18 V +2 CR +2 10/13/21, 12:57

  25. Christian Kuhn merged patch set 19 10/13/21, 12:57