Review main Merged

71442[BUGFIX] Populate composer name to extension key map early

Helmut Hummel CR +2 V +2 Easy +8 −5 updated 10/05/21, 14:59

Commit message

In order to be able to properly resolve package ordering,
the package manager resolves the dependencies of packages.

For dependencies to TYPO3 extensions, the Extension key is
used as dependency name. To resolve the extension key from
the composer name, an internal mapping array is used.

Dependency objects of each extension Package are created
on construction of the Package object. It can now happen that
composer package typo3/cms-backend is created before typo3/cms-core
is created, which leads to the situation that the package
typo3/cms-backend references typo3/cms-core as dependency, not
the extension key "core", which will later be expected during package
sorting by dependency.

To fix that, the mapping array is now created early, before any
TYPO3 extension Package is created.

Also make sure the list of composer (only) packages is cleaned from
TYPO3 extensions.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Nikita Hovratov +1

Issues 1

Files 1

Review log 1721

  1. Helmut Hummel uploaded patch set 1 10/05/21, 13:57

  2. Benjamin Franzke commented on patch set 1 10/05/21, 14:00

    Only master, we haven't branched.
  3. core-ci voted on patch set 1 V +1 10/05/21, 14:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17618

  4. Oli Bartsch updated the commit message in patch set 2 10/05/21, 14:13

  5. Oli Bartsch commented on patch set 2 10/05/21, 14:14

    Reply

    Done
  6. Helmut Hummel uploaded patch set 3 10/05/21, 14:19

  7. Nikita Hovratov commented on patch set 3 V +1 10/05/21, 14:24

    This fixed the upgrade of one of my projects.
    of
  8. core-ci voted on patch set 2 V +1 10/05/21, 14:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17619

  9. Oli Bartsch commented on patch set 3 V +1 CR +1 10/05/21, 14:29

    Thanks a lot. Verified on a composer-based v11 system.
  10. core-ci voted on patch set 3 V +1 10/05/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17620

  11. Oliver Klee commented on patch set 3 10/05/21, 14:37

    Thanks, Helmut! <3
  12. Helmut Hummel updated the commit message in patch set 4 10/05/21, 14:43

  13. Helmut Hummel commented on patch set 4 10/05/21, 14:43

    Reply

    Done
  14. Nikita Hovratov voted on patch set 4 V +1 10/05/21, 14:44

  15. Andreas Kienast voted on patch set 4 CR +1 10/05/21, 14:47

  16. Oli Bartsch voted on patch set 4 V +1 CR +1 10/05/21, 14:49

  17. Benjamin Franzke voted on patch set 4 V +1 10/05/21, 14:54

  18. Benjamin Franzke voted on patch set 4 CR +1 10/05/21, 14:54

  19. Helmut Hummel commented on patch set 4 V +2 CR +2 10/05/21, 14:56

    Thanks a bunch for the quick reviews!
  20. Helmut Hummel merged patch set 5 10/05/21, 14:57

  21. core-ci voted on patch set 4 V +1 10/05/21, 14:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17621