Review main Merged

71443[BUGFIX] Move SoftReferenceParserFactory DI config to correct sysext

Nikita Hovratov CR +2 V +2 Easy +4 −5 updated 10/05/21, 16:08

Commit message

The DI configuration should be in EXT:core not EXT:backend.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1416

  1. Nikita Hovratov uploaded patch set 1 10/05/21, 14:49

  2. core-ci voted on patch set 1 V +1 10/05/21, 15:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17622

  3. Oli Bartsch commented on patch set 1 10/05/21, 15:14

    @bnf Should we add this to the Core/ServiceProvider instead?
  4. Benni Mack voted on patch set 1 CR +1 10/05/21, 15:14

  5. Nikita Hovratov commented on patch set 1 10/05/21, 15:23

    Interestingly this doesn't happen with this patch anymore: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71442 We should add it explicitly nevertheless, I think.
  6. Helmut Hummel commented on patch set 1 CR -2 10/05/21, 15:29

    The original issue was a different one (messed up ordering of extensions)
  7. Nikita Hovratov commented on patch set 1 10/05/21, 15:36

    Reply

    Yes, but it revealed another bug: Cannot autowire service "TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory": argument "$runtimeCache" of method "__construct()" references interface "TYPO3\CMS\Core\Cache\Frontend\FrontendInterface" but no such service exists. This should be addressed, too.
  8. Helmut Hummel commented on patch set 1 CR -1 10/05/21, 15:36

    Wait, this thing is configured already, but in BACKEND extension? https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177/43/typo3/sysext/backend/Configuration/Services.yaml So, yes, we should move that over to core obviously...
  9. Nikita Hovratov commented on patch set 1 10/05/21, 15:38

    Reply

    OHH, thats why. :)))
  10. Nikita Hovratov uploaded patch set 2 10/05/21, 15:42

  11. Nikita Hovratov commented on patch set 2 10/05/21, 15:43

    Reply

    Good catch, thanks!
  12. Helmut Hummel commented on patch set 1 CR -1 10/05/21, 15:48

    Reply

    Yes, korrekt. The service definition of a core service done in backend extension, revealed a different bug. But this should be fixed as well. Can you take care of removing the definition from backend?
  13. Helmut Hummel voted on patch set 2 V +1 CR +1 10/05/21, 15:49

  14. core-ci voted on patch set 2 V +1 10/05/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17626

  15. Oli Bartsch voted on patch set 2 V +2 CR +2 10/05/21, 16:07

  16. Oli Bartsch merged patch set 3 10/05/21, 16:08