71443[BUGFIX] Move SoftReferenceParserFactory DI config to correct sysext
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Helmut Hummel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Nikita Hovratov uploaded patch set 1 10/05/21, 14:49
-
core-ci voted on patch set 1 V +1 10/05/21, 15:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17622
-
Oli Bartsch commented on patch set 1 10/05/21, 15:14
@bnf Should we add this to the Core/ServiceProvider instead? -
Benni Mack voted on patch set 1 CR +1 10/05/21, 15:14
-
Nikita Hovratov commented on patch set 1 10/05/21, 15:23
Interestingly this doesn't happen with this patch anymore: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71442 We should add it explicitly nevertheless, I think. -
Helmut Hummel commented on patch set 1 CR -2 10/05/21, 15:29
The original issue was a different one (messed up ordering of extensions) -
Nikita Hovratov commented on patch set 1 10/05/21, 15:36
Reply
Yes, but it revealed another bug: Cannot autowire service "TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory": argument "$runtimeCache" of method "__construct()" references interface "TYPO3\CMS\Core\Cache\Frontend\FrontendInterface" but no such service exists. This should be addressed, too. -
Helmut Hummel commented on patch set 1 CR -1 10/05/21, 15:36
Wait, this thing is configured already, but in BACKEND extension? https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177/43/typo3/sysext/backend/Configuration/Services.yaml So, yes, we should move that over to core obviously... -
Nikita Hovratov commented on patch set 1 10/05/21, 15:38
Reply
OHH, thats why. :))) -
Nikita Hovratov uploaded patch set 2 10/05/21, 15:42
-
Nikita Hovratov commented on patch set 2 10/05/21, 15:43
Reply
Good catch, thanks! -
Helmut Hummel commented on patch set 1 CR -1 10/05/21, 15:48
Reply
Yes, korrekt. The service definition of a core service done in backend extension, revealed a different bug. But this should be fixed as well. Can you take care of removing the definition from backend? -
Helmut Hummel voted on patch set 2 V +1 CR +1 10/05/21, 15:49
-
core-ci voted on patch set 2 V +1 10/05/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17626
-
Oli Bartsch voted on patch set 2 V +2 CR +2 10/05/21, 16:07
-
Oli Bartsch merged patch set 3 10/05/21, 16:08